DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=iREufVon99h4K1nU146g5f4TwPSNQyI4dCEXBE7s5w7tBeSj2aF8TTRnSgs14oWbr1tnbRLExjV1KGuveYYduWnIwQzYoUycZCSvQHeh5WVlure8ecT6UGzX/op3DprP;
Date: Tue, 29 Mar 2011 09:55:09 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>, Shyam_Iyer@Dell.com,
        mjg59@srcf.ucam.org, Narendra_K@Dell.com, viro@zeniv.linux.org.uk,
        sfr@canb.auug.org.au, linux-kernel@vger.kernel.org,
        linux-next@vger.kernel.org, Matt_Domsch@Dell.com,
        Charles_Rose@Dell.com, Jordan_Hargrave@Dell.com
Subject: Re: [PATCH] pci-label: Fix build failure when CONFIG_NLS is set to
 'm' by allmodconfig
Message-ID: <20110329095509.12d6024d@jbarnes-desktop>
In-Reply-To: <20110329094557.17cd57a1.randy.dunlap@oracle.com>
References: <20110223131536.GA16707@fedora14-r610.blr.amer.dell.com>
	<20110223131734.GA6275@srcf.ucam.org>
	<20110304101509.7eef7475@jbarnes-desktop>
	<20110328080220.1390d28e.randy.dunlap@oracle.com>
	<DBFB1B45AF80394ABD1C807E9F28D15702659CFB3D@BLRX7MCDC203.AMER.DELL.COM>
	<4D90EDE8.9070306@oracle.com>
	<87oc4u4rn4.fsf@devron.myhome.or.jp>
	<4D92063C.8040202@oracle.com>
	<8739m5519p.fsf@devron.myhome.or.jp>
	<20110329094557.17cd57a1.randy.dunlap@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2631
Lines: 88

On Tue, 29 Mar 2011 09:45:57 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Wed, 30 Mar 2011 01:39:46 +0900 OGAWA Hirofumi wrote:
> 
> > Randy Dunlap <randy.dunlap@oracle.com> writes:
> > 
> > >> config PCI_LABEL
> > >> 	bool
> > >>         select NLS
> > >>         depends on (DMI || ACPI)
> > >
> > > What sets/enables it then?
> > > or did you mean:
> > > 	def_bool y
> > > and in that case, should it be a user-visible & user-changeable kconfig option?
> > 
> > Whoops, last line was missed by copy&paste. It meant
> > 
> > config PCI_LABEL
> > 	bool
> > 	select NLS
> > 	depends on (DMI || ACPI)
> >         default y
> > 
> > And no, it shouldn't be user-changeable (it would be better to
> > invisible in .config. At make *config, already invisible.). Because
> > PCI_LABEL is not user config and not used in Makefile.
> > 
> > And yeah, if you like def_bool
> > 
> > config PCI_LABEL
> > 	def_bool y if (DMI || ACPI)
> > 	select NLS
> > 
> > I guess it would work (it should be just syntax sugar and equivalent).
> 
> 
> This patch seems to work for me.  Thanks.
> 
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Create a kconfig option symbol for PCI_LABEL and enable it
> when DMI || ACPI are enabled.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/pci/Kconfig  |    4 +++-
>  drivers/pci/Makefile |    4 ++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> --- linux-next-20110328.orig/drivers/pci/Kconfig
> +++ linux-next-20110328/drivers/pci/Kconfig
> @@ -88,4 +88,6 @@ config PCI_IOAPIC
>  	depends on HOTPLUG
>  	default y
>  
> -select NLS if (DMI || ACPI)
> +config PCI_LABEL
> +	def_bool y if (DMI || ACPI)
> +	select NLS
> --- linux-next-20110328.orig/drivers/pci/Makefile
> +++ linux-next-20110328/drivers/pci/Makefile
> @@ -56,10 +56,10 @@ obj-$(CONFIG_TILE) += setup-bus.o setup-
>  # ACPI Related PCI FW Functions
>  # ACPI _DSM provided firmware instance and string name
>  #
> -obj-$(CONFIG_ACPI)    += pci-acpi.o pci-label.o
> +obj-$(CONFIG_ACPI)    += pci-acpi.o
>  
>  # SMBIOS provided firmware instance and labels
> -obj-$(CONFIG_DMI)    += pci-label.o
> +obj-$(CONFIG_PCI_LABEL) += pci-label.o
>  
>  # Cardbus & CompactPCI use setup-bus
>  obj-$(CONFIG_HOTPLUG) += setup-bus.o
> 

Applied to my fixes branch, thanks Randy & Hirofumi-san.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/