Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754079Ab1C2Rd1 (ORCPT ); Tue, 29 Mar 2011 13:33:27 -0400 Received: from router-fw.net-space.pl ([89.174.63.77]:52541 "EHLO router-fw.net-space.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341Ab1C2Rd0 (ORCPT ); Tue, 29 Mar 2011 13:33:26 -0400 Date: Tue, 29 Mar 2011 19:32:21 +0200 From: Daniel Kiper To: David Rientjes Cc: Daniel Kiper , ian.campbell@citrix.com, akpm@linux-foundation.org, andi.kleen@intel.com, haicheng.li@linux.intel.com, fengguang.wu@intel.com, jeremy@goop.org, konrad.wilk@oracle.com, dan.magenheimer@oracle.com, v.tolstov@selfip.ru, pasik@iki.fi, dave@linux.vnet.ibm.com, wdauchy@gmail.com, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN() macro Message-ID: <20110329173221.GB30387@router-fw-old.local.net-space.pl> References: <20110328092412.GC13826@router-fw-old.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 30 On Mon, Mar 28, 2011 at 03:46:27PM -0700, David Rientjes wrote: > On Mon, 28 Mar 2011, Daniel Kiper wrote: > > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > > index 02ecb01..d342820 100644 > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -931,6 +931,9 @@ static inline unsigned long early_pfn_to_nid(unsigned long pfn) > > #define pfn_to_section_nr(pfn) ((pfn) >> PFN_SECTION_SHIFT) > > #define section_nr_to_pfn(sec) ((sec) << PFN_SECTION_SHIFT) > > > > +#define SECTION_ALIGN_UP(pfn) (((pfn) + PAGES_PER_SECTION - 1) & PAGE_SECTION_MASK) > > +#define SECTION_ALIGN_DOWN(pfn) ((pfn) & PAGE_SECTION_MASK) > > + > > #ifdef CONFIG_SPARSEMEM > > > > /* > > These are only valid for CONFIG_SPARSEMEM, so they need to be defined > conditionally. OK, however, I think that pfn_to_section_nr()/section_nr_to_pfn() should be defined conditionally, too. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/