Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753006Ab1C2S0I (ORCPT ); Tue, 29 Mar 2011 14:26:08 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:55235 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662Ab1C2S0G (ORCPT ); Tue, 29 Mar 2011 14:26:06 -0400 Date: Tue, 29 Mar 2011 14:25:55 -0400 From: Christoph Hellwig To: Jens Axboe Cc: Mike Snitzer , Tejun Heo , Markus Trippelsdorf , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Chris Mason , Vivek Goyal , Jeff Moyer Subject: Re: [PATCH] block: eliminate ELEVATOR_INSERT_REQUEUE Message-ID: <20110329182555.GA22898@infradead.org> References: <20110325151530.GA4414@swordfish.minsk.epam.com> <20110325152228.GA1707@gentoo.trippels.de> <20110325154024.GA16029@redhat.com> <4D8CB9C9.5010208@kernel.dk> <20110325185455.GA2969@redhat.com> <4D8CF202.9010809@kernel.dk> <20110326042156.GB28458@redhat.com> <20110328082321.GC16530@htj.dyndns.org> <20110328221547.GA1118@redhat.com> <4D91C8E7.5070205@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D91C8E7.5070205@kernel.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 496 Lines: 11 Btw, is there any need to actually keep the elv_insert interface? Itw has two callers in current mainline, two of them hardcode ELEVATOR_INSERT_REQUEUE as the reason and could opencode it, and the other cases could be merged into __elv_add_request. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/