Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754213Ab1C2Tn0 (ORCPT ); Tue, 29 Mar 2011 15:43:26 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:33011 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777Ab1C2TnZ (ORCPT ); Tue, 29 Mar 2011 15:43:25 -0400 Date: Tue, 29 Mar 2011 15:43:24 -0400 From: "'Christoph Hellwig'" To: Johannes Weiner Cc: "'Christoph Hellwig'" , Sean Noonan , "'Michel Lespinasse'" , "'linux-kernel@vger.kernel.org'" , Martin Bligh , Trammell Hudson , Christos Zoulas , "'linux-xfs@oss.sgi.com'" , Stephen Degler , "'linux-mm@kvack.org'" Subject: Re: XFS memory allocation deadlock in 2.6.38 Message-ID: <20110329194323.GA27840@infradead.org> References: <081DDE43F61F3D43929A181B477DCA95639B52FD@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5327@MSXAOA6.twosigma.com> <20110324174311.GA31576@infradead.org> <081DDE43F61F3D43929A181B477DCA95639B5349@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B534E@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5359@MSXAOA6.twosigma.com> <20110329192434.GA10536@infradead.org> <20110329193907.GK2310@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110329193907.GK2310@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 21 On Tue, Mar 29, 2011 at 09:39:07PM +0200, Johannes Weiner wrote: > > - ptr = vmalloc(size); > > + ptr = __vmalloc(size, GFP_NOFS | __GFP_HIGHMEM, PAGE_KERNEL); > > if (ptr) > > memset(ptr, 0, size); > > return ptr; > > Note that vmalloc is currently broken in that it does a GFP_KERNEL > allocation if it has to allocate page table pages, even when invoked > with GFP_NOFS: > > http://marc.info/?l=linux-mm&m=128942194520631&w=4 Oh great. In that case we had a chance to hit the deadlock even before the offending commit, just a much smaller one. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/