Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754707Ab1C2VN0 (ORCPT ); Tue, 29 Mar 2011 17:13:26 -0400 Received: from smtp-out.google.com ([74.125.121.67]:45226 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285Ab1C2VNW (ORCPT ); Tue, 29 Mar 2011 17:13:22 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=WTsuxaWk3tXiCxjgPiuKePx0oh/ji5qAoftYrIfC4CVzikB7sA5cHfGRgJ11wJYqpt ebnAZculQT8b1NBtktiQ== Date: Tue, 29 Mar 2011 14:11:53 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Daniel Kiper cc: ian.campbell@citrix.com, akpm@linux-foundation.org, andi.kleen@intel.com, haicheng.li@linux.intel.com, fengguang.wu@intel.com, jeremy@goop.org, konrad.wilk@oracle.com, dan.magenheimer@oracle.com, v.tolstov@selfip.ru, pasik@iki.fi, dave@linux.vnet.ibm.com, wdauchy@gmail.com, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN() macro In-Reply-To: <20110329173221.GB30387@router-fw-old.local.net-space.pl> Message-ID: References: <20110328092412.GC13826@router-fw-old.local.net-space.pl> <20110329173221.GB30387@router-fw-old.local.net-space.pl> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 22 On Tue, 29 Mar 2011, Daniel Kiper wrote: > > These are only valid for CONFIG_SPARSEMEM, so they need to be defined > > conditionally. > > OK, however, I think that pfn_to_section_nr()/section_nr_to_pfn() > should be defined conditionally, too. > Yes, and you could try removing this from include/linux/mm.h: #ifndef PFN_SECTION_SHIFT #define PFN_SECTION_SHIFT 0 #endif then we'll reveal anything using these conversion macros that don't rely on sparsemem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/