Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694Ab1C3Hme (ORCPT ); Wed, 30 Mar 2011 03:42:34 -0400 Received: from cantor.suse.de ([195.135.220.2]:48303 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175Ab1C3Hmd (ORCPT ); Wed, 30 Mar 2011 03:42:33 -0400 Date: Wed, 30 Mar 2011 09:42:31 +0200 From: Michal Hocko To: Zhu Yanhai Cc: KAMEZAWA Hiroyuki , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 0/3] Implementation of cgroup isolation Message-ID: <20110330074231.GB15394@tiehlicka.suse.cz> References: <20110328114430.GE5693@tiehlicka.suse.cz> <20110329090924.6a565ef3.kamezawa.hiroyu@jp.fujitsu.com> <20110329073232.GB30671@tiehlicka.suse.cz> <20110329165117.179d87f9.kamezawa.hiroyu@jp.fujitsu.com> <20110329085942.GD30671@tiehlicka.suse.cz> <20110329184119.219f7d7b.kamezawa.hiroyu@jp.fujitsu.com> <20110329111858.GF30671@tiehlicka.suse.cz> <20110329134223.GB3361@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1522 Lines: 45 On Tue 29-03-11 22:02:23, Zhu Yanhai wrote: > Hi, > > 2011/3/29 Michal Hocko : > > Isn't this an overhead that would slow the whole thing down. Consider > > that you would need to lookup page_cgroup for every page and touch > > mem_cgroup to get the limit. > > Current almost has did such things, say the direct reclaim path: > shrink_inactive_list() > ->isolate_pages_global() > ->isolate_lru_pages() > ->mem_cgroup_del_lru(for each page it wants to isolate) > and in mem_cgroup_del_lru() we have: > [code] > pc = lookup_page_cgroup(page); > /* > * Used bit is set without atomic ops but after smp_wmb(). > * For making pc->mem_cgroup visible, insert smp_rmb() here. > */ > smp_rmb(); > /* unused or root page is not rotated. */ > if (!PageCgroupUsed(pc) || mem_cgroup_is_root(pc->mem_cgroup)) > return; > [/code] > By calling mem_cgroup_is_root(pc->mem_cgroup) we already brought the > struct mem_cgroup into cache. > So probably things won't get worse at least. But we would still have to isolate and put back a lot of pages potentially. If we do not have those pages on the list we will skip them automatically. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/