Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755661Ab1C3JPO (ORCPT ); Wed, 30 Mar 2011 05:15:14 -0400 Received: from service87.mimecast.com ([94.185.240.25]:44596 "HELO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753863Ab1C3JPM convert rfc822-to-8bit (ORCPT ); Wed, 30 Mar 2011 05:15:12 -0400 Subject: Re: kmemleak for MIPS From: Catalin Marinas To: Maxin John Cc: Daniel Baluta , naveen yadav , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org In-Reply-To: References: <9bde694e1003020554p7c8ff3c2o4ae7cb5d501d1ab9@mail.gmail.com> <1300960540.32158.13.camel@e102109-lin.cambridge.arm.com> <1301395206.583.53.camel@e102109-lin.cambridge.arm.com> <1301399454.583.66.camel@e102109-lin.cambridge.arm.com> Organization: ARM Limited Date: Wed, 30 Mar 2011 10:15:05 +0100 Message-ID: <1301476505.29074.47.camel@e102109-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-OriginalArrivalTime: 30 Mar 2011 09:15:06.0492 (UTC) FILETIME=[F5C61BC0:01CBEEBA] X-MC-Unique: 111033010150808201 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 39 On Tue, 2011-03-29 at 20:36 +0100, Maxin John wrote: > I have prepared the combined patch for kmemleak porting to MIPS. After > applying the patch and enabling the kmemleak in Kernel, I can see one > kernel memleak reported during booting itself: ... > unreferenced object 0x8f90d000 (size 4096): > comm "swapper", pid 1, jiffies 4294937330 (age 815.000s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<80529644>] alloc_large_system_hash+0x2f8/0x410 > [<805383b4>] udp_table_init+0x4c/0x158 > [<805384dc>] udp_init+0x1c/0x94 > [<8053889c>] inet_init+0x184/0x2a0 > [<80100584>] do_one_initcall+0x174/0x1e0 > [<8051f348>] kernel_init+0xe4/0x174 > [<80103d4c>] kernel_thread_helper+0x10/0x18 If you for the kmemleak scan (via echo) a few times, do you get more leaks? The udp_table_init() function looks like it could leak some memory but I haven't seen it before. I'm not sure whether this is a false positive or a real leak. > > Please let me know your comments. > > Signed-off-by: Maxin B. John > Signed-off-by: Catalin Marinas I think the last line should be more like: Acked-by: Catalin Marinas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/