Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932362Ab1C3J7I (ORCPT ); Wed, 30 Mar 2011 05:59:08 -0400 Received: from service87.mimecast.com ([94.185.240.25]:33063 "HELO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755681Ab1C3J7G convert rfc822-to-8bit (ORCPT ); Wed, 30 Mar 2011 05:59:06 -0400 Subject: Re: kmemleak for MIPS From: Catalin Marinas To: Daniel Baluta Cc: Maxin John , naveen yadav , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Eric Dumazet In-Reply-To: References: <9bde694e1003020554p7c8ff3c2o4ae7cb5d501d1ab9@mail.gmail.com> <1300960540.32158.13.camel@e102109-lin.cambridge.arm.com> <1301395206.583.53.camel@e102109-lin.cambridge.arm.com> <1301399454.583.66.camel@e102109-lin.cambridge.arm.com> <1301476505.29074.47.camel@e102109-lin.cambridge.arm.com> Organization: ARM Limited Date: Wed, 30 Mar 2011 10:58:58 +0100 Message-ID: <1301479138.29074.52.camel@e102109-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-OriginalArrivalTime: 30 Mar 2011 09:58:59.0094 (UTC) FILETIME=[16ED4B60:01CBEEC1] X-MC-Unique: 111033010590103801 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1815 Lines: 42 On Wed, 2011-03-30 at 10:54 +0100, Daniel Baluta wrote: > >> unreferenced object 0x8f90d000 (size 4096): > >> comm "swapper", pid 1, jiffies 4294937330 (age 815.000s) > >> hex dump (first 32 bytes): > >> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > >> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > >> backtrace: > >> [<80529644>] alloc_large_system_hash+0x2f8/0x410 > >> [<805383b4>] udp_table_init+0x4c/0x158 > >> [<805384dc>] udp_init+0x1c/0x94 > >> [<8053889c>] inet_init+0x184/0x2a0 > >> [<80100584>] do_one_initcall+0x174/0x1e0 > >> [<8051f348>] kernel_init+0xe4/0x174 > >> [<80103d4c>] kernel_thread_helper+0x10/0x18 > > > > If you for the kmemleak scan (via echo) a few times, do you get more > > leaks? The udp_table_init() function looks like it could leak some > > memory but I haven't seen it before. I'm not sure whether this is a > > false positive or a real leak. > > Looking again at udp_init_table it seem that a memory leak is possible. > Could you post your .config and the full output of dmesg after booting. > > A situation where CONFIG_BASE_SMALL is 0, and > table->mask < UDP_HTABLE_SIZE_MIN - 1 would lead > to a memory leak. It's worth printing the table->mask on MIPS as well. I think have the same configuration on ARM and put some printk's but the table->mask is set to higher value and the second if condition is false. The checks could be simply reordered but I don't know the reasoning behind the current code sequence (I cc'ed Eric). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/