Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755838Ab1C3LXn (ORCPT ); Wed, 30 Mar 2011 07:23:43 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:58669 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754804Ab1C3LXm (ORCPT ); Wed, 30 Mar 2011 07:23:42 -0400 Message-ID: <4D9312BF.6010406@kernel.dk> Date: Wed, 30 Mar 2011 13:23:43 +0200 From: Jens Axboe MIME-Version: 1.0 To: Tejun Heo CC: Vivek Goyal , Jeff Moyer , Mike Snitzer , Markus Trippelsdorf , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Chris Mason Subject: Re: [PATCH] block: eliminate ELEVATOR_INSERT_REQUEUE References: <20110326042156.GB28458@redhat.com> <20110328082321.GC16530@htj.dyndns.org> <20110328221547.GA1118@redhat.com> <20110329175458.GE24485@redhat.com> <20110330074123.GA17523@htj.dyndns.org> <20110330075752.GC17523@htj.dyndns.org> <4D92E2CD.6000909@kernel.dk> <20110330080203.GD17523@htj.dyndns.org> <4D9302ED.4030807@kernel.dk> <20110330112040.GF17523@htj.dyndns.org> In-Reply-To: <20110330112040.GF17523@htj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 28 On 2011-03-30 13:20, Tejun Heo wrote: > Hello, Jens. > > On Wed, Mar 30, 2011 at 12:16:13PM +0200, Jens Axboe wrote: >> @@ -261,7 +261,7 @@ static bool blk_kick_flush(struct request_queue *q) >> q->flush_rq.end_io = flush_end_io; >> >> q->flush_pending_idx ^= 1; >> - elv_insert(q, &q->flush_rq, ELEVATOR_INSERT_REQUEUE); >> + __elv_add_request(q, &q->flush_rq, ELEVATOR_INSERT_FLUSH); > > Shouldn't this be list_add_tail(&rq->queuelist, &q->queue_head)? > __elv_add_request(FLUSH) calls back into blk_insert_flush() which > decomposes the flush request from FS into flush sequence. > blk_kick_flush() is used to insert the decomposed sequence requests > into the dispatch queue. Mid-air collision, I just sent that addon out to Sergey who tested. Yes of course it should be a regular list_add, the above is a braino. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/