Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755854Ab1C3LdM (ORCPT ); Wed, 30 Mar 2011 07:33:12 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:34238 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755760Ab1C3LdK (ORCPT ); Wed, 30 Mar 2011 07:33:10 -0400 Message-ID: <4D931498.9000505@ru.mvista.com> Date: Wed, 30 Mar 2011 15:31:36 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: Simon Wood CC: Greg Kroah-Hartman , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Brownell Subject: Re: [PATCH] pl25a1_support References: <1301456667-1648-1-git-send-email-simon@mungewell.org> In-Reply-To: <1301456667-1648-1-git-send-email-simon@mungewell.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1903 Lines: 63 Hello. On 30-03-2011 7:44, Simon Wood wrote: > Adds support for 'Windows Easy Transfer' cables based around the > Prolific PL-25A1 chip (includes Belkin F5U258& F5U279) > Patch originally suggested by David Brownell here: > http://www.mail-archive.com/netdev@vger.kernel.org/msg61926.html > Modified to work with latest kernel, tested with F5U279. > > Signed-off-by: Simon Wood [...] > diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c > index 08ad269..a20afac 100644 > --- a/drivers/net/usb/plusb.c > +++ b/drivers/net/usb/plusb.c [...] > @@ -89,13 +97,17 @@ static int pl_reset(struct usbnet *dev) > /* some units seem to need this reset, others reject it utterly. > * FIXME be more like "naplink" or windows drivers. > */ > - (void) pl_set_QuickLink_features(dev, > + int status; > + > + status = pl_set_QuickLink_features(dev, This line is indented with spaces ISO tab. > + if (status != 0 && netif_msg_probe(dev)) > + netif_dbg(dev, link, dev->net, "pl_reset --> %d\n", status); > return 0; > } Also, the above change doesn't seem to be related to the declared purpose of the patch, so seems to be a matter of another patch... > @@ -134,16 +153,16 @@ static struct usb_driver plusb_driver = { > > static int __init plusb_init(void) > { > - return usb_register(&plusb_driver); > + return usb_register(&plusb_driver); > } > module_init(plusb_init); > > static void __exit plusb_exit(void) > { > - usb_deregister(&plusb_driver); > + usb_deregister(&plusb_driver); > } Likewise, the whitespace fixes should be a matgter of a separate patch... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/