Message-ID: <4D93659F.2020900@redhat.com>
Date: Wed, 30 Mar 2011 19:17:19 +0200
From: Avi Kivity <avi@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.9
MIME-Version: 1.0
To: "Justin P. Mattock" <justinmattock@gmail.com>
CC: trivial@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]arch:x86:kvm:i8254.h Fix typo in kvm_pit
References: <1301501942-3937-1-git-send-email-justinmattock@gmail.com> <4D9359CC.6050508@redhat.com> <4D935AC3.2030509@gmail.com>
In-Reply-To: <4D935AC3.2030509@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1531
Lines: 45

On 03/30/2011 06:30 PM, Justin P. Mattock wrote:
> On 03/30/2011 09:26 AM, Avi Kivity wrote:
>> On 03/30/2011 06:19 PM, Justin P. Mattock wrote:
>>> The below patch changes base_addresss to base_address.
>>> Note: I have grepped for base_addresss and nothing shows up,
>>> grepping for base_address gets me lots of output, telling me that
>>> this is a typo, but could be wrong.
>>>
>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>>
>>> ---
>>> arch/x86/kvm/i8254.h | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/x86/kvm/i8254.h b/arch/x86/kvm/i8254.h
>>> index 46d08ca..c2fa48b 100644
>>> --- a/arch/x86/kvm/i8254.h
>>> +++ b/arch/x86/kvm/i8254.h
>>> @@ -33,7 +33,7 @@ struct kvm_kpit_state {
>>> };
>>>
>>> struct kvm_pit {
>>> - unsigned long base_addresss;
>>> + unsigned long base_address;
>>> struct kvm_io_device dev;
>>> struct kvm_io_device speaker_dev;
>>> struct kvm *kvm;
>>
>> Why not remove the variable completely?
>>
>
> didnt even think to completely remove the variable(figured it was used 
> somewhere).I will look at that and resend with removal of the variable 
> for you..

Well if it was used, you ought to have changed all of the users, no?

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/