Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754804Ab1C3SMM (ORCPT ); Wed, 30 Mar 2011 14:12:12 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:56319 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751755Ab1C3SML (ORCPT ); Wed, 30 Mar 2011 14:12:11 -0400 Message-ID: <4D937278.4050202@kernel.dk> Date: Wed, 30 Mar 2011 20:12:08 +0200 From: Jens Axboe MIME-Version: 1.0 To: Jeff Moyer CC: Tejun Heo , Vivek Goyal , Mike Snitzer , Markus Trippelsdorf , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Chris Mason , hch@infradead.org Subject: Re: block: eliminate ELEVATOR_INSERT_REQUEUE References: <20110328221547.GA1118@redhat.com> <20110329175458.GE24485@redhat.com> <20110330074123.GA17523@htj.dyndns.org> <20110330075752.GC17523@htj.dyndns.org> <4D92E2CD.6000909@kernel.dk> <20110330080203.GD17523@htj.dyndns.org> <20110330140123.GA28212@redhat.com> <20110330142751.GH17523@htj.dyndns.org> <20110330152248.GC1291@redhat.com> <20110330153024.GJ17523@htj.dyndns.org> <4D9364B0.5020604@kernel.dk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 28 On 2011-03-30 19:56, Jeff Moyer wrote: > Jens Axboe writes: > >> On 2011-03-30 17:30, Tejun Heo wrote: >>> On Wed, Mar 30, 2011 at 11:22:48AM -0400, Vivek Goyal wrote: >>>> So wee need this as stable fix because FLUSH request can get ahead of >>>> REQUEUED requests and it can break some drivers? >>> >>> Yes, I think so. All we need is just replacing elv_insert() calls in >>> blk-flush.c with list_add_tail(). Something like the following. I'll >>> test it and send a proper patch later. Thanks. >> >> I'd suggest I just mark the queued patch for stable. > > Could you document the nuance in that patch, please? Yeah I will. I rebase for-linus, it's not a "stable" branch as such. Today I mainly collected some items as not to drop them, I'll expand on the explanations in there. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/