Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756430Ab1C3Wlq (ORCPT ); Wed, 30 Mar 2011 18:41:46 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:62737 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756412Ab1C3Wlo (ORCPT ); Wed, 30 Mar 2011 18:41:44 -0400 Date: Wed, 30 Mar 2011 15:41:33 -0700 From: Randy Dunlap To: Artem Bityutskiy Cc: MTD list , lkml Subject: Re: [PATCH 2/2] UBI: do not select KALLSYMS_ALL Message-Id: <20110330154133.60d8f57e.randy.dunlap@oracle.com> In-Reply-To: <1301474416-8202-3-git-send-email-dedekind1@gmail.com> References: <1301474416-8202-1-git-send-email-dedekind1@gmail.com> <1301474416-8202-3-git-send-email-dedekind1@gmail.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: acsmt358.oracle.com [141.146.40.158] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4D93B1A4.0015:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1667 Lines: 52 On Wed, 30 Mar 2011 11:40:16 +0300 Artem Bityutskiy wrote: > From: Artem Bityutskiy > > All UBI needs is to make sure we stacktraces when UBI debugging > is enabled. It is enough to select KALLSYMS for this, KALLSYMS_ALL > is not necessary. > > And the current Kconfig line we have: > > select KALLSYMS_ALL if KALLSYMS && DEBUG_KERNEL > > is just too complex to be sane and right. But this "if" part there > is needed to prevent "unmet direct dependency" warnings, because > KALLSYMS_ALL depends on KALLSYMS and DEBUG_KERNEL, so we cannot > just select KALLSYMS_ALL. > > Anyway, this feels messy, and we do not seem to really need KALLSYMS_ALL, > so select KALLSYMS instead. > > Signed-off-by: Artem Bityutskiy > --- > drivers/mtd/ubi/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig > index 6abeb4f..4dcc752 100644 > --- a/drivers/mtd/ubi/Kconfig > +++ b/drivers/mtd/ubi/Kconfig > @@ -56,7 +56,7 @@ config MTD_UBI_DEBUG > bool "UBI debugging" > depends on SYSFS > select DEBUG_FS > - select KALLSYMS_ALL if KALLSYMS && DEBUG_KERNEL > + select KALLSYMS > help > This option enables UBI debugging. > > -- Acked-by: Randy Dunlap Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/