Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757128Ab1CaJ1j (ORCPT ); Thu, 31 Mar 2011 05:27:39 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:39645 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756440Ab1CaJ1i (ORCPT ); Thu, 31 Mar 2011 05:27:38 -0400 Date: Thu, 31 Mar 2011 11:27:21 +0200 From: Ingo Molnar To: Alan Cox Cc: Len Brown , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org, Len Brown , Linus Torvalds , Andrew Morton , Thomas Gleixner , "H. Peter Anvin" Subject: Re: [PATCH 2/9] x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flag Message-ID: <20110331092721.GA16570@elte.hu> References: <67e90d97e0a77df4acd0c75e1bacc7714e011f3e.1301550524.git.len.brown@intel.com> <20110331061247.GA24786@elte.hu> <20110331081800.GH5938@elte.hu> <20110331102355.17d30a38@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110331102355.17d30a38@lxorguk.ukuu.org.uk> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 36 * Alan Cox wrote: > > Do we know whether a distro adds this to the boot line? Do we know about users > > relying on it. > > I certainly had hardware that needed it. Don't any more but this is more > trying to rip out stuff without letting nature take its course. > > It's a trivial feature item. Yes. > > > Do we really need both? > > > > Probably not, as i said i do not disagree - i just think it should be more > > explicit. Make it a: "users of CPU models X beware" commit title, not 'remove > > inactive code' ... > > Just make the one config variable respond to both boot configuration > options. The parser is __init code anyway so discarded so the actual code > cost of compatibility is exactly NIL. Yeah, agreed. Btw., we used to auto-detect broken HLT systems IIRC - but that got lost already. We should at least honor the boot parameter. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/