Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933320Ab1CaJ1w (ORCPT ); Thu, 31 Mar 2011 05:27:52 -0400 Received: from ausc60pc101.us.dell.com ([143.166.85.206]:6447 "EHLO ausc60pc101.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933184Ab1CaJ1t convert rfc822-to-8bit (ORCPT ); Thu, 31 Mar 2011 05:27:49 -0400 X-Loopcount0: from 10.170.28.39 From: To: , CC: , , , , , , , , , Date: Thu, 31 Mar 2011 14:57:40 +0530 Subject: RE: [PATCH] pci-label: Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Thread-Topic: [PATCH] pci-label: Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Thread-Index: AcvuMhovWj9L7aPMTxiqqaoQY9fJQQBUiPNA Message-ID: References: <20110223131536.GA16707@fedora14-r610.blr.amer.dell.com> <20110223131734.GA6275@srcf.ucam.org> <20110304101509.7eef7475@jbarnes-desktop> <20110328080220.1390d28e.randy.dunlap@oracle.com> <4D90EDE8.9070306@oracle.com> <87oc4u4rn4.fsf@devron.myhome.or.jp> <4D92063C.8040202@oracle.com> <8739m5519p.fsf@devron.myhome.or.jp> <20110329094557.17cd57a1.randy.dunlap@oracle.com> <20110329095509.12d6024d@jbarnes-desktop> In-Reply-To: <20110329095509.12d6024d@jbarnes-desktop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3341 Lines: 109 > -----Original Message----- > From: Jesse Barnes [mailto:jbarnes@virtuousgeek.org] > Sent: Tuesday, March 29, 2011 10:25 PM > To: Randy Dunlap > Cc: OGAWA Hirofumi; Iyer, Shyam; mjg59@srcf.ucam.org; K, Narendra; > viro@zeniv.linux.org.uk; sfr@canb.auug.org.au; linux- > kernel@vger.kernel.org; linux-next@vger.kernel.org; Domsch, Matt; Rose, > Charles; Hargrave, Jordan > Subject: Re: [PATCH] pci-label: Fix build failure when CONFIG_NLS is set to > 'm' by allmodconfig > > On Tue, 29 Mar 2011 09:45:57 -0700 > Randy Dunlap wrote: > > > On Wed, 30 Mar 2011 01:39:46 +0900 OGAWA Hirofumi wrote: > > > > > Randy Dunlap writes: > > > > > > >> config PCI_LABEL > > > >> bool > > > >> select NLS > > > >> depends on (DMI || ACPI) > > > > > > > > What sets/enables it then? > > > > or did you mean: > > > > def_bool y > > > > and in that case, should it be a user-visible & user-changeable kconfig > option? > > > > > > Whoops, last line was missed by copy&paste. It meant > > > > > > config PCI_LABEL > > > bool > > > select NLS > > > depends on (DMI || ACPI) > > > default y > > > > > > And no, it shouldn't be user-changeable (it would be better to > > > invisible in .config. At make *config, already invisible.). Because > > > PCI_LABEL is not user config and not used in Makefile. > > > > > > And yeah, if you like def_bool > > > > > > config PCI_LABEL > > > def_bool y if (DMI || ACPI) > > > select NLS > > > > > > I guess it would work (it should be just syntax sugar and equivalent). > > > > > > This patch seems to work for me. Thanks. > > > > --- > > From: Randy Dunlap > > > > Create a kconfig option symbol for PCI_LABEL and enable it when DMI || > > ACPI are enabled. > > > > Signed-off-by: Randy Dunlap > > --- > > drivers/pci/Kconfig | 4 +++- > > drivers/pci/Makefile | 4 ++-- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > --- linux-next-20110328.orig/drivers/pci/Kconfig > > +++ linux-next-20110328/drivers/pci/Kconfig > > @@ -88,4 +88,6 @@ config PCI_IOAPIC > > depends on HOTPLUG > > default y > > > > -select NLS if (DMI || ACPI) > > +config PCI_LABEL > > + def_bool y if (DMI || ACPI) > > + select NLS > > --- linux-next-20110328.orig/drivers/pci/Makefile > > +++ linux-next-20110328/drivers/pci/Makefile > > @@ -56,10 +56,10 @@ obj-$(CONFIG_TILE) += setup-bus.o setup- # ACPI > > Related PCI FW Functions # ACPI _DSM provided firmware instance and > > string name # > > -obj-$(CONFIG_ACPI) += pci-acpi.o pci-label.o > > +obj-$(CONFIG_ACPI) += pci-acpi.o > > > > # SMBIOS provided firmware instance and labels > > -obj-$(CONFIG_DMI) += pci-label.o > > +obj-$(CONFIG_PCI_LABEL) += pci-label.o > > > > # Cardbus & CompactPCI use setup-bus > > obj-$(CONFIG_HOTPLUG) += setup-bus.o > > > > Applied to my fixes branch, thanks Randy & Hirofumi-san. Jesse, Randy and Hirofumi-san, Sorry for the late response and the build failure. Thank you for the patch to fix this. With regards, Narendra K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/