Message-ID: <4D948EC1.9080208@kernel.org>
Date: Thu, 31 Mar 2011 07:25:05 -0700
From: Yinghai Lu <yinghai@kernel.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8
MIME-Version: 1.0
To: Robin Holt <holt@sgi.com>
CC: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [RFC 2/2] Make x86 calibrate_delay run in parallel.
References: <20101215015840.390204279@gulag1.americas.sgi.com> <20101215015849.051095242@gulag1.americas.sgi.com> <AANLkTinoctZFKo4wBmrrdFggnjSj74QfqvEpz59sW15x@mail.gmail.com> <20110331092945.GD24046@sgi.com>
In-Reply-To: <20110331092945.GD24046@sgi.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1760
Lines: 49

On 03/31/2011 02:29 AM, Robin Holt wrote:
...
> I don't see how this patch would affect that.  Has this been tested on
> a multi-core intel cpu?  I will try to test it today when I get to the
> office.

Yes. I tested on our 8 sockets 10 cores intel cpu system and 8 cores system.
looks getting correct result.

>
> Additionally, it takes the bogomips value from being part of an output
> line and makes it a separate line.  On a 4096 cpu system, that will mean
> many additional lines of output.  In the past, we have seen that will
> cause a considerable slowdown as time is spent printing.  Fortunately,
> that is likely not going to slow things down as a secondary cpu will
> likely be doing that work while the boot cpu is allowed to continue with
> the boot.  Is there really a value for a normal boot to have this output?
> Can we remove the individual lines of output and just print the system
> BogoMips value?

that is easy. just update print_lpj.

static void __cpuinit print_lpj(int cpu, char *str, unsigned long lpj)
{
         static bool printed;

         if (printed)
                 return;

         pr_info("CPU%d: Calibrating delay%s"
                 "%lu.%02lu BogoMIPS (lpj=%lu)\n", cpu, str,
                 lpj/(500000/HZ), (lpj/(5000/HZ)) % 100, lpj);

         /* only print cpu0, and cpu1 */
         if (cpu)
                 printed = true;
}

current printing is for debug purpose, So we don't need to waiting the booting get done.
just checking it serial console.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/