Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758583Ab1CaQC4 (ORCPT ); Thu, 31 Mar 2011 12:02:56 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:39085 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758286Ab1CaQCy (ORCPT ); Thu, 31 Mar 2011 12:02:54 -0400 Subject: Re: [PATCH 05/12] mm: alloc_contig_range() added From: Dave Hansen To: Marek Szyprowski Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, Michal Nazarewicz , Kyungmin Park , Andrew Morton , KAMEZAWA Hiroyuki , Ankita Garg , Daniel Walker , Johan MOSSBERG , Mel Gorman , Pawel Osciak In-Reply-To: <1301577368-16095-6-git-send-email-m.szyprowski@samsung.com> References: <1301577368-16095-1-git-send-email-m.szyprowski@samsung.com> <1301577368-16095-6-git-send-email-m.szyprowski@samsung.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Thu, 31 Mar 2011 09:02:41 -0700 Message-ID: <1301587361.31087.1040.camel@nimitz> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 23 On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: > + ret = 0; > + while (!PageBuddy(pfn_to_page(start & (~0UL << ret)))) > + if (WARN_ON(++ret >= MAX_ORDER)) > + return -EINVAL; Holy cow, that's dense. Is there really no more straightforward way to do that? In any case, please pull the ++ret bit out of the WARN_ON(). Some people like to do: #define WARN_ON(...) do{}while(0) to save space on some systems. -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/