From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Grant Likely <grant.likely@secretlab.ca>
CC: Linux Kernel <linux-kernel@vger.kernel.org>
Date: Thu, 31 Mar 2011 16:20:04 -0500
Subject: RE: gpio: pca953x: prevent freeing IRQ 0 on probe error
Thread-Topic: gpio: pca953x: prevent freeing IRQ 0 on probe error
Thread-Index: Acvv5QtmsVcSyTj1QDuYAQfp/6KW7wABEP8g
Message-ID: <0D753D10438DA54287A00B027084269764D1B0C9B0@AUSP01VMBX24.collaborationhost.net>
References: <201103251502.54348.hartleys@visionengravers.com>
 <20110331204833.GA32522@ponder.secretlab.ca>
In-Reply-To: <20110331204833.GA32522@ponder.secretlab.ca>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1030
Lines: 25

On Thursday, March 31, 2011 1:49 PM, Grant Likely wrote:
> On Fri, Mar 25, 2011 at 03:02:54PM -0700, H Hartley Sweeten wrote:
>> If CONFIG_GPIO_PCA953X_IRQ is enabled and an error occurs in the probe
>> before pca953x_irq_setup() is called chip->client->irq will be 0 due to
>> the kmalloc.  pca953x_irq_teardown() will then try to free_irq(0, chip)
>> which will produce a:
>> 
>> 	WARN(1, "Trying to free already-free IRQ %d\n", irq);
>> 
>> Add an error path to prevent this.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>
> Thanks for catching this Hartley.
>
> Ben also submitted a patch for this and I ended up looking at his patch 
> first, so that is what's applied.  :-)

Not a problem. Thanks!
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/