Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922Ab1DABTM (ORCPT ); Thu, 31 Mar 2011 21:19:12 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:45399 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587Ab1DABTJ (ORCPT ); Thu, 31 Mar 2011 21:19:09 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=GHZnerkSrc8IiI7YK0u0+Yj4TUCdeRayhncfyibGA6lNYLhdGYaNWhKz5iG5S+8F96 HPETrVJfRlafeu8tnAy1WalUMtD/XKVJ6G6i/XSjjRoJy+MIjBR7cddXf6UNd9O6SNU1 WFFGyUkCoO8fLLsaWk7h3IV0lPznd2unpjlaY= Subject: Re: [PATCH 1/3] memcg: mark init_section_page_cgroup() properly From: Namhyung Kim To: Andrew Morton Cc: Paul Menage , Li Zefan , containers@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki In-Reply-To: <1300452855-10194-1-git-send-email-namhyung@gmail.com> References: <1300452855-10194-1-git-send-email-namhyung@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 01 Apr 2011 10:18:56 +0900 Message-ID: <1301620736.1496.9.camel@leonhard> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 44 2011-03-18 (금), 21:54 +0900, Namhyung Kim: > The commit ca371c0d7e23 ("memcg: fix page_cgroup fatal error > in FLATMEM") removes call to alloc_bootmem() in the function > so that it can be marked as __meminit to reduce memory usage > when MEMORY_HOTPLUG=n. > > Signed-off-by: Namhyung Kim > Cc: KAMEZAWA Hiroyuki > --- > mm/page_cgroup.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 5bffada7cde1..2d1a0fa01d7b 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -105,8 +105,7 @@ struct page_cgroup *lookup_page_cgroup(struct page *page) > return section->page_cgroup + pfn; > } > > -/* __alloc_bootmem...() is protected by !slab_available() */ > -static int __init_refok init_section_page_cgroup(unsigned long pfn) > +static int __meminit init_section_page_cgroup(unsigned long pfn) > { > struct mem_section *section = __pfn_to_section(pfn); > struct page_cgroup *base, *pc; Andrew, could you please have a look these patches too and consider applying them in your tree? I can resend them (with given Acked-by lines) if you want. Thanks. -- Regards, Namhyung Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/