Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755416Ab1DAJc7 (ORCPT ); Fri, 1 Apr 2011 05:32:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53201 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755193Ab1DAJc5 (ORCPT ); Fri, 1 Apr 2011 05:32:57 -0400 Date: Fri, 1 Apr 2011 11:32:40 +0200 From: Karel Zak To: Miklos Szeredi Cc: "Aneesh Kumar K. V" , victor.vde@gmail.com, util-linux@vger.kernel.org, linuxram@us.ibm.com, viro@zeniv.linux.org.uk, ejmarkow@yahoo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Lennart Poettering Subject: Re: [BUG] libmount misparses mountinfo on Linux v2.6.39-rc1 Message-ID: <20110401093240.GA11012@nb.net.home> References: <19860.58082.277944.875401@gargle.gargle.HOWL> <87d3l62z3k.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1895 Lines: 54 On Fri, Apr 01, 2011 at 10:45:48AM +0200, Miklos Szeredi wrote: > On Fri, 01 Apr 2011, Aneesh Kumar K. V wrote: > > On Thu, 31 Mar 2011 22:24:01 +0200, victor.vde@gmail.com wrote: > > > /proc/self/mountinfo on Linux v2.6.39-rc1 includes the UUID of ext4 > > > and ext3 mounts, for example: > > > > > > 15 1 8:3 / / rw,noatime uuid:c645234d-9756-4d84-825e-6fe999252a34 - ext4 /dev/sda3 rw,user_xattr,acl,barrier=1,data=ordered > > > > > > It seems the hyphens in the uuid confuse the parser > > > mnt_parse_mountinfo_line in tab_parse.c of libmount in util-linux. > > > > shouldn't the parser look for " " followed by "-" followed by " " as the > > field seperator ? > > > > I am adding Miklos and Ram Pai to CC to check whether the kernel or the libmount > > should be fixed ? > > I think libmount should be fixed, though there is always the question > of backward compatibility. The parser uses rc = sscanf(s, "%u " /* (1) id */ "%u " /* (2) parent */ "%u:%u " /* (3) maj:min */ "%ms " /* (4) mountroot */ "%ms " /* (5) target */ "%ms" /* (6) vfs options (fs-independent) */ "%*[^-]" /* (7) optional fields */ "- " /* (8) separator */ "%ms " /* (9) FS type */ "%ms " /* (10) source */ "%ms", /* (11) fs options (fs specific) */ note that almost the same code is in systemd. > However I don't see how the kernel could be fixed, given that libmount > doesn't seem to parse escape sequences (e.g. "\040" for space), which > it also should. It calls unmangle_string() for all fields, so all sequences should be decoded. Karel -- Karel Zak http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/