Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757887Ab1DAPYn (ORCPT ); Fri, 1 Apr 2011 11:24:43 -0400 Received: from casper.infradead.org ([85.118.1.10]:48790 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639Ab1DAPYm (ORCPT ); Fri, 1 Apr 2011 11:24:42 -0400 Date: Fri, 1 Apr 2011 12:24:31 -0300 From: Arnaldo Carvalho de Melo To: Peter Zijlstra Cc: Frederic Weisbecker , David Ahern , Akihiro Nagai , Ingo Molnar , linux-kernel@vger.kernel.org, Masami Hiramatsu , 2nddept-manager@sdl.hitachi.co.jp, Paul Mackerras Subject: Re: [PATCH -tip v3 3/6] perf branch trace: print pid and command Message-ID: <20110401152431.GA26938@ghostprotocols.net> References: <20110324113137.20235.42265.stgit@localhost6.localdomain6> <20110324113209.20235.61900.stgit@localhost6.localdomain6> <4D8B79E6.2050603@gmail.com> <4D8C6B1B.70409@hitachi.com> <4D8CAE74.9080805@gmail.com> <4D906450.1040809@hitachi.com> <4D909BBB.5020500@gmail.com> <20110401151313.GC2335@nowhere> <1301670917.4859.696.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1301670917.4859.696.camel@twins> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 34 Em Fri, Apr 01, 2011 at 05:15:17PM +0200, Peter Zijlstra escreveu: > On Fri, 2011-04-01 at 17:13 +0200, Frederic Weisbecker wrote: > > On Mon, Mar 28, 2011 at 08:31:23AM -0600, David Ahern wrote: > > > On 03/28/11 04:34, Akihiro Nagai wrote: > > > >> from is sample->ip? to is sample->addr? In the above example > > > >> 0x39d3015260 is the value from sample->addr, 1526f is sample->ip which > > > >> resolves to _dl_next_ld_env_entry from /lib64/ld-2.13.so. > > > > Yes. > > > > In this example, resolved address is only sample->ip (branch from). > > > > We need the resolved address of sample->addr (branch to) too, because > > > > both of them are addresses of execution code. > > > > > > Ok, now I understand. In that case add conversion of sample->addr to > > > symbols to perf-script. > > > > I agree that we should rather use perf script for branch dumps. > > Sorry Akihiro, I think we suggested you to create this dedicated > > perf branch by the past. But then perf script became the vanilla dump > > tool in the middle and it seems more suitable today. > > > > We can still create a perf branch later in order to produce some more > > advanced post-processing tools. But for sample dumps perf script (which starts > > to show itself as a misnomer BTW) seems to be the right place. > > Why do something with snakes if its perfectly possible to do in C ? He is not meaning using python, hence the "misnomer" comment. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/