Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758589Ab1DAR2J (ORCPT ); Fri, 1 Apr 2011 13:28:09 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:61992 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758468Ab1DAR2H (ORCPT ); Fri, 1 Apr 2011 13:28:07 -0400 Subject: Re: accessing vfpinstr macros from outside vfp directory From: Will Deacon To: Neil Leeder Cc: Russell King - ARM Linux , Jean Pihet , Sheetal Sahasrabudhe , Nicolas Pitre , Bryan Huntsman , linux-arm-kernel@lists.infradead.org, jamie.iles@picochip.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <4D924966.2050707@codeaurora.org> References: <4D924966.2050707@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 01 Apr 2011 18:27:23 +0100 Message-ID: <1301678843.17592.5.camel@e102144-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 26 Neil, On Tue, 2011-03-29 at 22:04 +0100, Neil Leeder wrote: > Any opinions on what would be the best thing to do here? Choices appear to be: > > 1) allow the relative include path of ../vfp/vfpinstr.h > 2) move the definitions of fmrx, fmxr from vfp/vfpinstr.h to include/asm/vfp.h > 3) move vfp/vfpinstr.h to include/asm > 4) other...? > > If it helps, I can create a patch for whichever is considered the preferred solution. > I personally don't find option (1) that offensive - Bryan seemed to differ though so perhaps option (2) would keep him happy? I don't think option (3) is sensible given that the majority of the header file is private to /vfp. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/