Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758639Ab1DARcA (ORCPT ); Fri, 1 Apr 2011 13:32:00 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:45150 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758555Ab1DARb6 (ORCPT ); Fri, 1 Apr 2011 13:31:58 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=MlqwM0ubKJnoNeh8vO9pILfiLZ+soduk9YweDrizIrd/X/Jv77q/LkIoNA6b4izsMU lZxf2q/9+4S3/hKX2aCRy6iyK4dPibEf3UDmbtNui5pKOik6TICWQQEtW+tPGoSCmamk QDGtHt5yZLmd2rMt1dT0lCJk7rJmahIAl2Yw0= MIME-Version: 1.0 In-Reply-To: <4D9603D8.2010709@caviumnetworks.com> References: <4D9603D8.2010709@caviumnetworks.com> Date: Fri, 1 Apr 2011 10:31:57 -0700 Message-ID: Subject: Re: [PATCH v2] MIPS: Kernel crashes on boot with SPARSEMEM + HIGHMEM enabled From: Kevin Cernekee To: David Daney , Ralf Baechle Cc: Michael Sundius , David VomLehn , Dave Hansen , Andy Whitcroft , Jon Fraser , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, stable@kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 21 On Fri, Apr 1, 2011 at 9:56 AM, David Daney wrote: > I think this may do the same thing as my patch: > > http://patchwork.linux-mips.org/patch/1988/ > > Although my patch had different motivations, and changes some other things > around too. I noticed that some of the other architectures have started using the APIs for memory setup. Do you think this would be useful on MIPS, as part of a larger refactoring of bootmem_init() ? What I liked about Michael's fix was that it is simple and straightforward enough to meet the stable tree criteria. Long term it would probably be a good idea to clean up the memory init code and get rid of the cut&paste "for" loops. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/