Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758766Ab1DAS4R (ORCPT ); Fri, 1 Apr 2011 14:56:17 -0400 Received: from terminus.zytor.com ([198.137.202.10]:38287 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758051Ab1DAS4R (ORCPT ); Fri, 1 Apr 2011 14:56:17 -0400 Message-ID: <4D961FBC.2030105@zytor.com> Date: Fri, 01 Apr 2011 11:55:56 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 MIME-Version: 1.0 To: Stefano Stabellini CC: Yinghai Lu , Ingo Molnar , "Rafael J. Wysocki" , Michael Leun , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Mike Pagano Subject: Re: 2.6.38.2 breaks suspend to disk References: <20110330203215.0a1a41a7@xenia.leun.net> <20110331090524.07ad0069@xenia.leun.net> <201103312348.53678.rjw@sisk.pl> <4D94FE37.8070109@kernel.org> <4D95F80D.7070201@kernel.org> <4D95FBDD.9050901@zytor.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 598 Lines: 15 On 04/01/2011 11:14 AM, Stefano Stabellini wrote: >> Why the heck should we save and restore CR4 only for x86-64? > > AFAICT it has always been the case since the beginning of time (Initial > git repository build). Doesn't change the fact that at least conceptually it's wrong; consider bits like NX. Rafael, do you have any thoughts on this? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/