Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756546Ab1DBA1N (ORCPT ); Fri, 1 Apr 2011 20:27:13 -0400 Received: from mout.perfora.net ([74.208.4.194]:56282 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786Ab1DBA1L (ORCPT ); Fri, 1 Apr 2011 20:27:11 -0400 Date: Fri, 1 Apr 2011 20:26:33 -0400 From: Stephen Wilson To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Jonathan Corbet , Christoph Hellwig , Masami Hiramatsu , Thomas Gleixner , Ananth N Mavinakayanahalli , Oleg Nesterov , Andrew Morton , SystemTap , Jim Keniston , Roland McGrath , Andi Kleen , LKML Subject: Re: [PATCH v3 2.6.39-rc1-tip 6/26] 6: Uprobes: register/unregister probes. Message-ID: <20110402002633.GA13277@fibrous.localdomain> References: <20110401143223.15455.19844.sendpatchset@localhost6.localdomain6> <20110401143338.15455.98645.sendpatchset@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110401143338.15455.98645.sendpatchset@localhost6.localdomain6> User-Agent: Mutt/1.5.19 (2009-01-05) X-Provags-ID: V02:K0:zHMjlRuTSf7PR6MafPTAdNDEVy05/1t/yKXAo9iwiSa +2+L1o9Q9D7WBOFhrZ5L2lJDdvc/m8z0uFUih2olX07rAMK6Gg xUsexkRFwX/HdP5LbxeAoLy4Ah3Z5O+u/1MHwp3sb/HhFRvfnr ojx/vzJmp2yLdUlIP3jLwdr3YvD3be7FiKT5dB232XMJWHFsLv SjgeHrJSnF8ODhiuA/TpagTb/xJ12MAx4rIwDxX3EI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 57 On Fri, Apr 01, 2011 at 08:03:38PM +0530, Srikar Dronamraju wrote: > +int register_uprobe(struct inode *inode, loff_t offset, > + struct uprobe_consumer *consumer) > +{ > + struct prio_tree_iter iter; > + struct list_head try_list, success_list; > + struct address_space *mapping; > + struct mm_struct *mm, *tmpmm; > + struct vm_area_struct *vma; > + struct uprobe *uprobe; > + int ret = -1; > + > + if (!inode || !consumer || consumer->next) > + return -EINVAL; > + > + uprobe = uprobes_add(inode, offset); > + if (!uprobe) > + return -ENOMEM; > + > + INIT_LIST_HEAD(&try_list); > + INIT_LIST_HEAD(&success_list); > + mapping = inode->i_mapping; > + > + mutex_lock(&uprobes_mutex); > + if (uprobe->consumers) { > + ret = 0; > + goto consumers_add; > + } > + > + spin_lock(&mapping->i_mmap_lock); > + vma_prio_tree_foreach(vma, &iter, &mapping->i_mmap, 0, 0) { > + loff_t vaddr; > + > + if (!atomic_inc_not_zero(&vma->vm_mm->mm_users)) > + continue; > + > + mm = vma->vm_mm; > + if (!valid_vma(vma)) { > + mmput(mm); > + continue; > + } > + > + vaddr = vma->vm_start + offset; > + vaddr -= vma->vm_pgoff << PAGE_SHIFT; What happens here when someone passes an offset that is out of bounds for the vma? Looks like we could oops when the kernel tries to set a breakpoint. Perhaps check wrt ->vm_end? -- steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/