Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450Ab1DCXOn (ORCPT ); Sun, 3 Apr 2011 19:14:43 -0400 Received: from mail-qy0-f181.google.com ([209.85.216.181]:44190 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736Ab1DCXOl convert rfc822-to-8bit (ORCPT ); Sun, 3 Apr 2011 19:14:41 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; b=lN7BJzs1rAfwRu8QRhHbLRsybliJTJTH5Nixh0lxfUTwEnKoKHQmaS7kpQoLeRyXgN 3s00WVXnMLhfFUGI+cXsJ1VgHdU2mEhd3UJA1OCaAR3eU2ZLBaJRtB24P3fxPxxnHhKX BwRBMI2x/bfYY9jSiGCrrPUpUlOgpngjh0V9w= MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <4D98F8E7.6030703@fusionio.com> References: <20110402112037.ca288d7b.sfr@canb.auug.org.au> <4D98F1DA.1060203@fusionio.com> <4D98F2FF.7090201@fusionio.com> <4D98F66D.9040808@fusionio.com> <4D98F8E7.6030703@fusionio.com> Date: Mon, 4 Apr 2011 01:14:40 +0200 Message-ID: Subject: Re: linux-next: Tree for April 1 [BROKEN ubifs when CONFIG_DEBUG_SECTION_MISMATCH=y]s From: Sedat Dilek To: Jens Axboe Cc: Stephen Rothwell , "dedekind1@gmail.com" , "linux-next@vger.kernel.org" , LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4036 Lines: 100 On Mon, Apr 4, 2011 at 12:47 AM, Jens Axboe wrote: > On 2011-04-04 00:38, Sedat Dilek wrote: >> On Mon, Apr 4, 2011 at 12:36 AM, Jens Axboe wrote: >>> On 2011-04-04 00:33, Sedat Dilek wrote: >>>> On Mon, Apr 4, 2011 at 12:21 AM, Jens Axboe wrote: >>>>> On 2011-04-04 00:19, Sedat Dilek wrote: >>>>>> On Mon, Apr 4, 2011 at 12:16 AM, Jens Axboe wrote: >>>>>>> On 2011-04-02 13:02, Sedat Dilek wrote: >>>>>>>> On Sat, Apr 2, 2011 at 12:14 PM, Sedat Dilek wrote: >>>>>>>>> On Sat, Apr 2, 2011 at 2:20 AM, Stephen Rothwell wrote: >>>>>>>>>> cc'ing Jens ... >>>>>>>>>> >>>>>>>>>> On Fri, 1 Apr 2011 20:22:41 +0200 Sedat Dilek wrote: >>>>>>>>>>> >>>>>>>>>>> On Fri, Apr 1, 2011 at 7:02 PM, Artem Bityutskiy wrote: >>>>>>>>>>>> On Fri, 2011-04-01 at 18:10 +0200, Sedat Dilek wrote: >>>>>>>>>>>>> On Fri, Apr 1, 2011 at 6:06 PM, Stephen Rothwell wrote: >>>>>>>>>>>>>> Cc'ing Artem, >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Fri, 1 Apr 2011 17:55:52 +0200 Sedat Dilek wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> With CONFIG_DEBUG_SECTION_MISMATCH=y set, I see in my build.log: >>>>>>>>>>>>>>> ... >>>>>>>>>>>>>>> MODPOST 2742 modules >>>>>>>>>>>>>>> ... >>>>>>>>>>>>>>> ERROR: "empty_aops" [fs/ubifs/ubifs.ko] undefined! >>>>>>>>>>>>>>> make[5]: *** [__modpost] Error 1 >>>>>>>>>>>>>>> make[4]: *** [modules] Error 2 >>>>>>>>>>>>>>> make[3]: *** [sub-make] Error 2 >>>>>>>>>>>>>>> make[2]: *** [all] Error 2 >>>>>>>>>>>>>>> make[2]: Leaving directory >>>>>>>>>>>>>>> `/home/sd/src/linux-2.6/linux-2.6.39-rc1/debian/build/build_i386_none_686-iniza' >>>>>>>>>>>>>>> >>>>>>>> [...] >>>>>>>>> Just FYI: >>>>>>>>> I contacted Jens last night and he refreshed his for-linus GIT branch. >>>>>>>>> Adding missing include did not fix the issue. >>>>>>>>> I am trying with the attached one. >>>>>>>>> >>>>>>>>> - Sedat - >>>>>>>>> >>>>>>>> >>>>>>>> I have split the single patch into two, first reflects ther build-error. >>>>>>>> The second considers {inode,file}_operations have also undefined >>>>>>>> functions by using "unified" empty_{iops,fops} as used in other fs/* >>>>>>>> files. >>>>>>> >>>>>>> What are these patches against? Not for-next nor my for-linus. >>>>>>> >>>>>> >>>>>> I tested with linux-next (next-20110401) as base and pulled-in your >>>>>> for-linus GIT branch. >>>>> >>>>> Then perhaps there was some merge error. There's no empty_aops defined >>>>> in my tree in nilfs_mapping_init(), for instance. >>>>> >>>>> Are you using an old for-linus? >>>>> >>>> >>>> I dropped the idea of exporting empty_aops via include/linux/fs.h (& >>>> changes in fs/inode.c) as it did not work as intended. >>>> As an alternative I used empty_{aops,iops,fops} only in >>>> fs/nilfs2/page.c and fs/ubifs/xattr.c where it is only needed (for >>>> example for aops: static const struct address_space_operations >>>> empty_aops {}; etc.) >>> >>> I'm asking one thing, you are replying with something else. The patches >>> you sent do NOT apply to for-linus. >>> >> >> Oh, I am sorry. I checkout your tree and adapt. > > I believe that you need is this, plain and simple. > > diff --git a/fs/inode.c b/fs/inode.c > index b818730..33c963d 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -130,6 +130,7 @@ static DECLARE_RWSEM(iprune_sem); >  */ >  const struct address_space_operations empty_aops = { >  }; > +EXPORT_SYMBOL(empty_aops); > >  /* >  * Statistics gathering.. > As you like.... To have a unified variable nomenclature/usage I would like to see in fs/ubifs/xattr.c: s/none_inode_operations/empty_iops s/none_file_operations/empty_fops - Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/