Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923Ab1DDHtg (ORCPT ); Mon, 4 Apr 2011 03:49:36 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:55652 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890Ab1DDHtf (ORCPT ); Mon, 4 Apr 2011 03:49:35 -0400 Date: Mon, 04 Apr 2011 00:48:56 -0700 (PDT) Message-Id: <20110404.004856.55863268.davem@davemloft.net> To: benh@kernel.crashing.org Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically From: David Miller In-Reply-To: <1301887630.2549.71.camel@pasglop> References: <1301882694.2549.53.camel@pasglop> <1301887630.2549.71.camel@pasglop> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 20 From: Benjamin Herrenschmidt Date: Mon, 04 Apr 2011 13:27:10 +1000 > +struct device_node * __weak pcibios_get_phb_of_node(struct pci_bus *bus) > +{ > + /* This should only be called for PHBs */ > + if (WARN_ON(bus->self || bus->parent)) > + return NULL; This WARN_ON() will always trigger on sparc, because we use the OF device tree object at the "parent" of the PCI bus devices we create for the PCI controller domains. I'm really surprised you don't link the PCI bus roots into the rest of the global device hierarchy on powerpc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/