Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753908Ab1DDIBs (ORCPT ); Mon, 4 Apr 2011 04:01:48 -0400 Received: from bonnie-vm4.ifh.de ([141.34.50.21]:45361 "EHLO smtp.ifh.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751459Ab1DDIBr (ORCPT ); Mon, 4 Apr 2011 04:01:47 -0400 X-Greylist: delayed 1177 seconds by postgrey-1.27 at vger.kernel.org; Mon, 04 Apr 2011 04:01:46 EDT Date: Mon, 4 Apr 2011 09:42:04 +0200 (CEST) From: Patrick Boettcher X-X-Sender: pboettch@pub1.ifh.de To: Florian Mickler cc: Mauro Carvalho Chehab , oliver@neukum.org, linux-kernel@vger.kernel.org, Linux Media Mailing List Subject: Re: [media] dib0700: get rid of on-stack dma buffers In-Reply-To: <1301851423-21969-1-git-send-email-florian@mickler.org> Message-ID: References: <1301851423-21969-1-git-send-email-florian@mickler.org> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 43 Hi Florian, On Sun, 3 Apr 2011, Florian Mickler wrote: > Hi, > > since I got no reaction[1] on the vp702x driver, I proceed with the > dib0700. > > There are multiple drivers in drivers/media/dvb/dvb-usb/ which use > usb_control_msg to perform dma to stack-allocated buffers. This is a bad idea > because of cache-coherency issues and on some platforms the stack is mapped > virtually and also lib/dma-debug.c warn's about it at runtime. > > Patches to ec168, ce6230, au6610 and lmedm04 were already tested and reviewed > and submitted for inclusion [2]. Patches to a800, vp7045, friio, dw2102, m920x > and opera1 are still waiting for for review and testing [3]. > > This patch to dib0700 is a fix for a warning seen and reported by Zdenek > Kabalec in Bug #15977 [4]. > > Florian Mickler (2): > [media] dib0700: get rid of on-stack dma buffers For this one we implemented an alternative. See here: http://git.linuxtv.org/pb/media_tree.git?a=commit;h=16b54de2d8b46e48c5c8bdf9b350eac04e8f6b46 which I pushed, but obviously forgot to send the pull-request. This is done now. For the second patch I will incorperate it as soon as I find the time. best regards, -- Patrick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/