Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755372Ab1DDTQJ (ORCPT ); Mon, 4 Apr 2011 15:16:09 -0400 Received: from usmamail.tilera.com ([206.83.70.75]:35692 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754862Ab1DDTQH (ORCPT ); Mon, 4 Apr 2011 15:16:07 -0400 Message-ID: <4D9A18F3.3090506@tilera.com> Date: Mon, 4 Apr 2011 15:16:03 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.15) Gecko/20110303 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: James Hogan CC: David Howells , Koichi Yasutake , Andrew Morton , FUJITA Tomonori , James Hogan , Konrad Rzeszutek Wilk , Paul Mundt , Arnd Bergmann , , Subject: Re: [PATCH] tile,mn10300: add device parameter to dma_cache_sync() References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 35 On 4/4/2011 11:21 AM, James Hogan wrote: > From: James Hogan > > Note: I'm not in a position to compile test this patch, but I don't > foresee any problems. > > Since v2.6.20 "Pass struct dev pointer to dma_cache_sync()" > (d3fa72e4556ec1f04e46a0d561d9e785ecaa173d), dma_cache_sync() takes a > struct dev pointer, but these appear to be missing from the tile and > mn10300 implementations, so add them. > > Signed-off-by: James Hogan > --- > arch/mn10300/include/asm/dma-mapping.h | 2 +- > arch/tile/include/asm/dma-mapping.h | 3 ++- > arch/tile/kernel/pci-dma.c | 2 +- This change looks fine for tile (not compile-tested but pretty obvious), so Acked-by: Chris Metcalf assuming you're planning to push this up yourself. Apparently we've never tried to build anything that uses this API (sata_dwc_460ex.c, lasi_82596.c, 53c700.c, etc.). -- Chris Metcalf, Tilera Corp. http://www.tilera.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/