Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755823Ab1DDWrs (ORCPT ); Mon, 4 Apr 2011 18:47:48 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:60104 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753920Ab1DDWrr (ORCPT ); Mon, 4 Apr 2011 18:47:47 -0400 Date: Mon, 4 Apr 2011 14:55:11 -0700 From: Matt Helsley To: Andrew Morton Cc: "Serge E. Hallyn" , containers@lists.linux-foundation.org, Nathan Lynch , linux-kernel@vger.kernel.org, Alexey Dobriyan Subject: Re: [PATCH 05/10] Core checkpoint/restart support code Message-ID: <20110404215511.GA27628@count0.beaverton.ibm.com> References: <1298936432-29607-1-git-send-email-ntl@pobox.com> <1298936432-29607-6-git-send-email-ntl@pobox.com> <20110403190324.GD15044@hallyn.com> <1301929228.31531.39.camel@tp-t61> <20110404151017.GA4857@hallyn.com> <1301931608.31531.49.camel@tp-t61> <20110404162753.GA3456@hallyn.com> <20110404104119.78189678.akpm@linux-foundation.org> <20110404185119.GB4782@peq.hallyn.com> <20110404124222.fd5eb85b.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110404124222.fd5eb85b.akpm@linux-foundation.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2717 Lines: 57 On Mon, Apr 04, 2011 at 12:42:22PM -0700, Andrew Morton wrote: > On Mon, 4 Apr 2011 13:51:20 -0500 "Serge E. Hallyn" wrote: > > > Quoting Andrew Morton (akpm@linux-foundation.org): > > > On Mon, 4 Apr 2011 11:27:53 -0500 "Serge E. Hallyn" wrote: > > > > > > > Andrew (Cc:d), did you see this thread go by, and it did it look > > > > in any way more palatable to you? Have you had any thoughts on > > > > checkpoint/restart in the last few months? Or did that horse quietly > > > > die over winter? > > > > > > argh, it was the victim of LIFO. > > > > > > All I can say at this stage is that I'll be interested next time it > > > comes past, sorry. > > > > Thanks, that's good to know. > > > > As you know, we started with a minimal patchset, then grew it over time > > to answer the "but how will you (xyz) without uglifying the kernel". > > Would you recommend we go back to keeping a separate minimal patchset, > > or that we develop on the current, pretty feature-full version? I'm not > > convinced believe there will be bandwidth to keep two trees and do both > > justice. > > The minimal patchset is too minimal for Oren's use and the maximal > patchset seems to have run aground on general kernel sentiment. So I > guess you either take the minimal patchset and make it less minimal or > take the maximal patchset and make it less maximal, ending up with the > same thing. How's that for hand-waving useless obviousnesses :) > > One obvious approach is to merge the minimal patchset then, over time, > sneak more stuff into it so we end up with the maximal patchset which > people didn't like. Don't do that :) Yes, merging this minimal patch set early is obviously premature. It seems clear from your statement above that "the maximal patchset seems to have run aground on general kernel sentiment" -- pushing that set isn't going to make any progress. So I think we're left with modifying the new minimal patch set. However I think we need some review before we continue modifying it. We had a minimal patch set which evolved into the current maximal set. It never really got the reviews outside our little group that it needed. Now we're back with a new minimal patch set. You're asking us to do the same thing and expect different results -- stack more patches on top and expect to get it reviewed. OK, but what reason do we have to believe this time will be any different? Cheers, -Matt Helsley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/