Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743Ab1DEHl3 (ORCPT ); Tue, 5 Apr 2011 03:41:29 -0400 Received: from casper.infradead.org ([85.118.1.10]:58207 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828Ab1DEHl2 convert rfc822-to-8bit (ORCPT ); Tue, 5 Apr 2011 03:41:28 -0400 Subject: Re: BUG: sleeping function called from invalid context at kernel/mutex.c From: Peter Zijlstra To: Thomas Gleixner Cc: Xiaotian Feng , LKML , Ingo Molnar , Venkatesh Pallipadi , Suresh Siddha , "H. Peter Anvin" , "Rafael J. Wysocki" In-Reply-To: References: <4D970CB6.3070604@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Tue, 05 Apr 2011 09:41:16 +0200 Message-ID: <1301989276.2225.1.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 813 Lines: 16 On Sat, 2011-04-02 at 21:12 +0200, Thomas Gleixner wrote: > > And it is safe enough for the resume case as well, it simply cannot go > to sleep because nothing else can hold that mutex in the early resume > code. We take the mutex during early boot as well, but there the might > sleep checks are disabled. And we should do the very same thing in the > early resume code as well. Rafael, PeterZ ??? the $subject text sound like it triggered might_sleep(), and that had a system_state != SYSTEM_RUNNING bail condition, but then, I've no clue what resume looks like. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/