Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249Ab1DEPdU (ORCPT ); Tue, 5 Apr 2011 11:33:20 -0400 Received: from mga09.intel.com ([134.134.136.24]:14810 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754032Ab1DEPdR (ORCPT ); Tue, 5 Apr 2011 11:33:17 -0400 Message-Id: X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.63,304,1299484800"; d="scan'208";a="623893069" Date: Tue, 05 Apr 2011 16:32:54 +0100 To: Pekka Enberg Subject: Re: [PATCH] drm/i915: Disable all outputs early, before KMS takeover Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Linus Torvalds , keith.packard@intel.com, danie.vettel@ffwll.ch References: <1302014055-13708-1-git-send-email-chris@chris-wilson.co.uk> From: Chris Wilson In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2239 Lines: 50 On Tue, 5 Apr 2011 18:11:37 +0300, Pekka Enberg wrote: > Hi Chris, > > On Tue, Apr 5, 2011 at 5:34 PM, Chris Wilson wrote: > > If the outputs are active and continuing to access the GATT when we > > teardown the PTEs, then there is a potential for us to hang the GPU. > > The hang tends to be a PGTBL_ER with either an invalid host access or > > an invalid display plane fetch. > > > > v2: Reorder IRQ initialisation to defer until after GEM is setup. > > > > Reported-by: Pekka Enberg > > Signed-off-by: Chris Wilson > > Tested-by: Daniel Vetter (855GM) > > I no longer get a blank screen after boot but flicker got more > aggressive during boot (it calms down after I've logged in). I see > tons of these in dmesg that don't appear with 2.6.39-rc1: Well the PGTBL_ER is still there. I'm thinking it might worth a check to see if that is asserted even before we start... > [ 10.175843] [drm:intel_update_fbc], > [ 10.183100] [drm:i915_driver_irq_handler], pipe A underrun > [ 10.185085] [drm:i915_driver_irq_handler], pipe A underrun > [ 10.186082] [drm:i915_driver_irq_handler], pipe A underrun > [ 10.187087] [drm:i915_driver_irq_handler], pipe A underrun > [ 10.189082] [drm:i915_driver_irq_handler], pipe A underrun > [ 10.190085] [drm:i915_driver_irq_handler], pipe A underrun If I'm understanding the dmesg correctly, then these start even before we setup the first crtc. Whether that means we're not completely disabling all outputs or that we set a register incorrectly I don't know. Comparing an intel_reg_dumper with and without the patch applied might give a clue if it is a register that is set differently due to the reordering. The other question is of course whether you see those in 2.6.39-rc1 as well... Probably not since they will correspond with the increased flicker. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/