Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755216Ab1DEQ3h (ORCPT ); Tue, 5 Apr 2011 12:29:37 -0400 Received: from am1ehsobe002.messaging.microsoft.com ([213.199.154.205]:4117 "EHLO AM1EHSOBE002.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752339Ab1DEQ3g convert rfc822-to-8bit (ORCPT ); Tue, 5 Apr 2011 12:29:36 -0400 X-SpamScore: -20 X-BigFish: VS-20(zzbb2dK9371P1432N98dKzz1202hzzz2dh2a8h637h668h839h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: KIP:(null);UIP:(null);IPVD:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Message-ID: <4D9B4363.8010606@freescale.com> Date: Tue, 5 Apr 2011 13:29:23 -0300 From: Fabio Estevam Organization: Freescale Semiconductor User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= CC: Richard Purdie , Andrew Morton , , , H Hartley Sweeten , Russell King - ARM Linux , Sascha Hauer , Subject: Re: [PATCH] leds: provide helper to register "leds-gpio" devices References: <20110405073030.GI13963@pengutronix.de> <1301992655-8514-1-git-send-email-u.kleine-koenig@pengutronix.de> <4D9B3FA8.1010407@freescale.com> In-Reply-To: <4D9B3FA8.1010407@freescale.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 38 On 4/5/2011 1:13 PM, Fabio Estevam wrote: > Hi Uwe, > > On 4/5/2011 5:37 AM, Uwe Kleine-König wrote: >> This function makes a deep copy of the platform data to allow it to live >> in init memory. >> The definition cannot go into leds-gpio.c because it needs to be builtin >> to be usable by platforms. >> >> Signed-off-by: Uwe Kleine-König > > I tested your patch on a MX53EVK board, but I could only build it after unselecting the mmc driver. > > This is the error I got when mmc was selected: > > CC drivers/mmc/card/mmc_test.o > LD drivers/mmc/card/built-in.o > CC drivers/mmc/core/sdio_io.o > In file included from include/linux/mmc/host.h:13, > from drivers/mmc/core/sdio_io.c:12: > include/linux/leds.h:220: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gpio_led_register_device' > make[3]: *** [drivers/mmc/core/sdio_io.o] Error 1 > make[2]: *** [drivers/mmc/core] Error 2 > make[1]: *** [drivers/mmc] Error 2 > make: *** [drivers] Error 2 If I declare it as "platform_device *gpio_led_register_device" then it builds fine. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/