Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754637Ab1DERgl (ORCPT ); Tue, 5 Apr 2011 13:36:41 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:54420 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753868Ab1DERgk (ORCPT ); Tue, 5 Apr 2011 13:36:40 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6307"; a="84111541" Message-ID: <4D9B5327.1070709@codeaurora.org> Date: Tue, 05 Apr 2011 10:36:39 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Simon Glass CC: Omar Ramirez Luna , Russell King , lk , lak Subject: Re: [PATCH] ARM: BUG() dies silently References: <1301602523-9906-1-git-send-email-omar.ramirez@ti.com> <4D959058.7010606@codeaurora.org> <4D981EAB.8070209@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 37 On 4/4/2011 6:55 PM, Simon Glass wrote: > On Sun, Apr 3, 2011 at 12:15 AM, Stephen Boyd wrote: >> Yes I've seen your patch (and even posted comments on it which have not >> been responded to). > Hi Stephen, > > Not yet! Don't worry I will get to it. I like the suggestion and am > pleased that you pointed me to it, thank you. > Great! >> Correct me if I'm wrong, but that patch with CONFIG_BUG=n would lead to >> the same error that Omar is seeing because the code only modifies the >> bug infrastructure when CONFIG_BUG=y. > Well if CONFIG_BUG=n then there is no bug infrastructure, The whole > file is skipped and it falls back to the asm-generic/bug.h which has > even more #ifdefs in it. But I think we end up here: > > #define BUG() do {} while(0) > > After all the patch removes the *(int*)0 = 0 code by virtue of > CONFIG_GENERIC_BUG=y, right? If I have this wrong then I will have to > break out the C preprocessor... > Ah you're right. Too many ifdefs going on there. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/