Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755651Ab1DFLLY (ORCPT ); Wed, 6 Apr 2011 07:11:24 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:49630 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755621Ab1DFLLW (ORCPT ); Wed, 6 Apr 2011 07:11:22 -0400 From: Jamie Iles To: linux-kernel@vger.kernel.org Cc: linux@arm.linux.org.uk, tglx@linutronix.de, cbouatmailru@gmail.com, grant.likely@secretlab.ca, arnd@arndb.de, nico@fluxnic.net, Jamie Iles Subject: [RFC PATCH 5/7] basic_mmio_gpio: detect output method at probe time Date: Wed, 6 Apr 2011 12:11:01 +0100 Message-Id: <1302088263-12714-6-git-send-email-jamie@jamieiles.com> X-Mailer: git-send-email 1.7.4 In-Reply-To: <1302088263-12714-1-git-send-email-jamie@jamieiles.com> References: <1302088263-12714-1-git-send-email-jamie@jamieiles.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4930 Lines: 162 Rather than detecting the output method each time in the .set() callback, do it at probe time and set the appropriate callback. Signed-off-by: Jamie Iles Cc: Anton Vorontsov Cc: Grant Likely --- drivers/gpio/basic_mmio_gpio.c | 85 +++++++++++++++++++++++++++------------- 1 files changed, 58 insertions(+), 27 deletions(-) diff --git a/drivers/gpio/basic_mmio_gpio.c b/drivers/gpio/basic_mmio_gpio.c index afa854b..500eb6ae 100644 --- a/drivers/gpio/basic_mmio_gpio.c +++ b/drivers/gpio/basic_mmio_gpio.c @@ -162,14 +162,6 @@ static void bgpio_set(struct gpio_chip *gc, unsigned int gpio, int val) unsigned long mask = bgc->pin2mask(bgc, gpio); unsigned long flags; - if (bgc->reg_set) { - if (val) - bgc->write_reg(bgc->reg_set, mask); - else - bgc->write_reg(bgc->reg_clr, mask); - return; - } - spin_lock_irqsave(&bgc->lock, flags); if (val) @@ -182,6 +174,18 @@ static void bgpio_set(struct gpio_chip *gc, unsigned int gpio, int val) spin_unlock_irqrestore(&bgc->lock, flags); } +static void bgpio_set_with_clear(struct gpio_chip *gc, unsigned int gpio, + int val) +{ + struct bgpio_chip *bgc = to_bgpio_chip(gc); + unsigned long mask = bgc->pin2mask(bgc, gpio); + + if (val) + bgc->write_reg(bgc->reg_set, mask); + else + bgc->write_reg(bgc->reg_clr, mask); +} + static int bgpio_dir_in(struct gpio_chip *gc, unsigned int gpio) { return 0; @@ -189,7 +193,8 @@ static int bgpio_dir_in(struct gpio_chip *gc, unsigned int gpio) static int bgpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) { - bgpio_set(gc, gpio, val); + gc->set(gc, gpio, val); + return 0; } @@ -239,14 +244,52 @@ static int bgpio_setup_accessors(struct platform_device *pdev, return 0; } +/* + * Create the device and allocate the resources. For setting GPIO's there are + * two supported configurations: + * + * - single output register resource (named "dat"). + * - set/clear pair (named "set" and "clr"). + * + * For the single output register, this drives a 1 by setting a bit and a zero + * by clearing a bit. For the set clr pair, this drives a 1 by setting a bit + * in the set register and clears it by setting a bit in the clear register. + * The configuration is detected by which resources are present. + */ +static int bgpio_setup_io(struct platform_device *pdev, + struct bgpio_chip *bgc) +{ + struct resource *res_set; + struct resource *res_clr; + + res_set = platform_get_resource_byname(pdev, IORESOURCE_MEM, "set"); + res_clr = platform_get_resource_byname(pdev, IORESOURCE_MEM, "clr"); + if (res_set && res_clr) { + if (resource_size(res_set) != resource_size(res_clr) || + resource_size(res_set) != bgc->bits) + return -EINVAL; + + bgc->reg_set = bgpio_request_and_map(&pdev->dev, res_set); + bgc->reg_clr = bgpio_request_and_map(&pdev->dev, res_clr); + if (!bgc->reg_set || !bgc->reg_clr) + return -ENOMEM; + + bgc->gc.set = bgpio_set_with_clear; + } else if (res_set || res_clr) { + return -EINVAL; + } else { + bgc->gc.set = bgpio_set; + } + + return 0; +} + static int __devinit bgpio_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct bgpio_pdata *pdata = dev_get_platdata(dev); struct bgpio_chip *bgc; struct resource *res_dat; - struct resource *res_set; - struct resource *res_clr; resource_size_t dat_sz; int bits; int ret; @@ -273,21 +316,6 @@ static int __devinit bgpio_probe(struct platform_device *pdev) if (!bgc->reg_dat) return -ENOMEM; - res_set = platform_get_resource_byname(pdev, IORESOURCE_MEM, "set"); - res_clr = platform_get_resource_byname(pdev, IORESOURCE_MEM, "clr"); - if (res_set && res_clr) { - if (resource_size(res_set) != resource_size(res_clr) || - resource_size(res_set) != dat_sz) - return -EINVAL; - - bgc->reg_set = bgpio_request_and_map(dev, res_set); - bgc->reg_clr = bgpio_request_and_map(dev, res_clr); - if (!bgc->reg_set || !bgc->reg_clr) - return -ENOMEM; - } else if (res_set || res_clr) { - return -EINVAL; - } - if (pdata) { bgc->gc.base = pdata->base; if (pdata->ngpio > 0) @@ -300,6 +328,10 @@ static int __devinit bgpio_probe(struct platform_device *pdev) if (ret) return ret; + ret = bgpio_setup_io(pdev, bgc); + if (ret) + return ret; + spin_lock_init(&bgc->lock); bgc->data = bgc->read_reg(bgc->reg_dat); @@ -307,7 +339,6 @@ static int __devinit bgpio_probe(struct platform_device *pdev) bgc->gc.direction_input = bgpio_dir_in; bgc->gc.direction_output = bgpio_dir_out; bgc->gc.get = bgpio_get; - bgc->gc.set = bgpio_set; bgc->gc.dev = dev; bgc->gc.label = dev_name(dev); -- 1.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/