Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756769Ab1DFUFP (ORCPT ); Wed, 6 Apr 2011 16:05:15 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:53662 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049Ab1DFUFN convert rfc822-to-8bit (ORCPT ); Wed, 6 Apr 2011 16:05:13 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=iDUOtMN4RQRSKtBVd8mo8Ps/qCUovgwgLvmBXdtmKEKXiAYyNphmVUdofXCAGzxLuY e5uh6Ny9PBqv0nH6DQ2bjIQ7gWxeI+CeP+WEhNWHfzAC5Wv8GcL5wOfPcus6Vu3r8F9/ i5HX0nnov6LLFmfbDAYdzbHYWSMnSjECW12BU= MIME-Version: 1.0 In-Reply-To: <20110406.125256.102558618.davem@davemloft.net> References: <05ae3c2fdd2db1f6a2fd3cd900164667e615f4f8.1301711868.git.lucian.grijincu@gmail.com> <20110406.125256.102558618.davem@davemloft.net> From: Lucian Adrian Grijincu Date: Wed, 6 Apr 2011 22:04:53 +0200 Message-ID: Subject: Re: [PATCH 01/24] sysctl: net: call unregister_net_sysctl_table where needed To: David Miller Cc: adobriyan@gmail.com, ebiederm@xmission.com, tavi@cs.pub.ro, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 33 On Wed, Apr 6, 2011 at 9:52 PM, David Miller wrote: > Oops, hmmm...  Can this actually cause any real problems currently? > > If so I'd like to toss this specific patch into net-2.6 Nope: void unregister_net_sysctl_table(struct ctl_table_header *header) { unregister_sysctl_table(header); } EXPORT_SYMBOL_GPL(unregister_net_sysctl_table); But I thought that in the future, if something special needs to be done for unregister_net_sysctl_table, it would be better to have these consistent. I'll do a check on all the tree to see if there are other cases. Another approach would be to remove unregister_net_sysctl_table, as it does nothing different of unregister_sysctl_table and let our future selves deal with the problem. Can you tell me what you'd like? --  . ..: Lucian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/