Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937Ab1DFVpb (ORCPT ); Wed, 6 Apr 2011 17:45:31 -0400 Received: from smtp-out.google.com ([74.125.121.67]:20534 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756816Ab1DFVpa convert rfc822-to-8bit (ORCPT ); Wed, 6 Apr 2011 17:45:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=clRqdMFwASTCIL7SreTfxmuFSn87O1WxXFrFGFkFWSnzRPUGHfgTm218AL91J75+rU tqL/VTOcQzU4KEfugcDQ== MIME-Version: 1.0 In-Reply-To: References: <1302038697-28985-1-git-send-email-natg@google.com> <20110405223814.GA21350@ericsson.com> <20110406000528.GB21350@ericsson.com> <20110406004312.GA21882@ericsson.com> <20110406030220.GB22535@ericsson.com> Date: Wed, 6 Apr 2011 14:45:21 -0700 Message-ID: Subject: Re: [PATCH] Make all it87 drivers SMP safe. From: Natarajan Gurumoorthy To: Paul Gortmaker Cc: Guenter Roeck , Jean Delvare , Wim Van Sebroeck , Mike Waychison , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , "linux-watchdog@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 35 Paul, Comments are below. On Wed, Apr 6, 2011 at 2:35 PM, Paul Gortmaker wrote: > On Wed, Apr 6, 2011 at 3:04 AM, Natarajan Gurumoorthy wrote: >> Guenter, >> ? ? ?Thank you for your feedback. I found an easier way to deal with >> the it87_lock.c file. I do not need to move it to the driver/misc >> directory. The easier thing to do was to move the IT87_LOCK entry to >> the beginning of the drivers/watchdog/Kconfig file. This moves the >> entry before the "menuconfig WATCHDOG" entry. They use the exact same >> trick in drivers/misc/Kconfig file. The very first lines of >> drivers/watchdog/Kconfig file will look something like this: > > Is the Kconfig even warranted? ?I mean, if there is a shared resource > and it needs locking, then just apply the locking. ? Where is the value > in adding another Kconfig? > The reason we are forced to do this is that all the it87 drivers are usually modules. We need a global lock that is compiled into the kernel if one or more of these drivers are selected. If none of them are specified then the lock is not built into the kernel. The Kconfig entry that I have put is not human selectable. When any IT87 driver is selected it will select IT87_LOCK there by compiling the lock into the kernel. -- Regards Nat Gurumoorthy AB6SJ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/