Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757258Ab1DGDc2 (ORCPT ); Wed, 6 Apr 2011 23:32:28 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:15640 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756990Ab1DGDc0 (ORCPT ); Wed, 6 Apr 2011 23:32:26 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 06 Apr 2011 20:32:26 -0700 From: wni@nvidia.com To: ccross@android.com, konkers@android.com, olof@lixom.net, linux@arm.linux.org.uk, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: swarren@nvidia.com, Wei Ni Subject: [PATCH v1] tegra: remove the clock sleepable WARNING Date: Thu, 7 Apr 2011 11:30:00 +0800 Message-Id: <1302147000-17854-1-git-send-email-wni@nvidia.com> X-Mailer: git-send-email 1.7.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1876 Lines: 45 From: Wei Ni The dvfs will try to init clock, it trickles down to the child clock. Part of that init is to set cansleep flag. When setting a clock as cansleep, in which case the entire list of clocks is traversed to set the children as cansleep as well. in here, the clk_set_cansleep can only be called on clocks that are the sole parent of all of their child clocks, meaning the child clock can not be reparented onto a different, possibly non-sleeping, clock. If the child clock has the set_parent callback, the driver warns that this case is not proper, it will show WARNING: "can't make child clock xxx of xxx sleepable if it's parent could change" But Some clocks only has one parent, although they have set_parent callback. These clocks' flags is set to 0, not MUX, it means they can not be reparented. So we can remove this WARNING if !(flags & MUX). Signed-off-by: Wei Ni --- v1: This patch against linux-tegra-2.6.37 branch in git://android.git.kernel.org/kernel/tegra.git arch/arm/mach-tegra/clock.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-tegra/clock.c b/arch/arm/mach-tegra/clock.c index f556977..d0b6b45 100644 --- a/arch/arm/mach-tegra/clock.c +++ b/arch/arm/mach-tegra/clock.c @@ -187,7 +187,8 @@ static void __clk_set_cansleep(struct clk *c) if (child->parent != c) continue; - WARN(child->ops && child->ops->set_parent, + WARN(child->ops && child->ops->set_parent + && (child->flags & MUX), "can't make child clock %s of %s " "sleepable if it's parent could change", child->name, c->name); -- 1.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/