Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751848Ab1DGFff (ORCPT ); Thu, 7 Apr 2011 01:35:35 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:63262 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633Ab1DGFfe (ORCPT ); Thu, 7 Apr 2011 01:35:34 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6308"; a="84426413" Message-ID: <4D9D4D23.6000805@codeaurora.org> Date: Wed, 06 Apr 2011 22:35:31 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: Simon Glass CC: linux-arm-kernel@lists.infradead.org, Russell King , Tony Lindgren , Nicolas Pitre , Catalin Marinas , Joe Perches , Laurent Pinchart , Alexander Shishkin , Phil Carmody , Rabin Vincent , linux-kernel@vger.kernel.org, Omar Ramirez Luna , Dave Martin , Simon Glass Subject: Re: [PATCH v3] ARM: Use generic BUG() handler References: <1302131890-20953-1-git-send-email-sjg@chromium.org> In-Reply-To: <1302131890-20953-1-git-send-email-sjg@chromium.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1627 Lines: 43 On 4/6/2011 4:18 PM, Simon Glass wrote: > v3: Remove old BUG() implementation in favor of this one. > Remove the Backtrace: message (will submit this separately). > Use ARM_EXIT_KEEP() so that some architectures can dump exit text at link time > thanks to Stephen Boyd (although since we always > define GENERIC_BUG this might be academic.) Its not entirely academic because CONFIG_BUG=n and CONFIG_SMP_ON_UP=n would allow us to remove the exit text. This could be huge for people who want to cram kernel's onto space constrained devices. > Rebase to linux-2.6.git master. > > Change-Id: I07d77c832e816f5ad2390e25f466ddf750adecf4 Don't forget to remove these before submitting to the patch tracker (and sending to the list). > diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h > index 4d88425..2914724 100644 > --- a/arch/arm/include/asm/bug.h > +++ b/arch/arm/include/asm/bug.h > @@ -3,21 +3,58 @@ > > > #ifdef CONFIG_BUG > -#ifdef CONFIG_DEBUG_BUGVERBOSE > -extern void __bug(const char *file, int line) __attribute__((noreturn)); > - > -/* give file/line information */ > -#define BUG() __bug(__FILE__, __LINE__) Does anybody reference __bug() anymore? If not you can remove that too. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/