Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 18 Jul 2002 18:57:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 18 Jul 2002 18:57:30 -0400 Received: from chaos.analogic.com ([204.178.40.224]:61826 "EHLO chaos.analogic.com") by vger.kernel.org with ESMTP id ; Thu, 18 Jul 2002 18:57:29 -0400 Date: Thu, 18 Jul 2002 19:04:02 -0400 (EDT) From: "Richard B. Johnson" Reply-To: root@chaos.analogic.com To: Yann Dirson cc: Alan Cox , linux-kernel@vger.kernel.org, kaos@ocs.com.au Subject: Re: Generic modules documentation is outdated In-Reply-To: <20020718232535.GB8165@bylbo.nowhere.earth> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2281 Lines: 71 On Fri, 19 Jul 2002, Yann Dirson wrote: > On Thu, Jul 18, 2002 at 11:48:41PM +0100, Alan Cox wrote: > > On Thu, 2002-07-18 at 22:02, Yann Dirson wrote: > > > - I have installed no proprietary driver, all loaded drivers declare to be > > > "GPL" or "Dual BSD/GPL". > > > > Something you loaded was missing a MODULE_LICENSE tag - modern insmod > > will warn on this one > > I wrote: > > I found a good candidate in the Apple HFS module > > Hm, no, I found the real one (although HFS has the problem): > > # modprobe ppp_deflate > Warning: loading /lib/modules/2.4.18+preempt/kernel/drivers/net/ppp_deflate.o will taint the kernel: non-GPL license - BSD without advertisement clause > > I'm pretty sure the "BSD without advertisement clause" license should not > taint the kernel, should it ? > > And even if there is an obscure license incompatibility, there is a problem > in that this module is in the stock kernels, and should then be advertised > as such (or maybe removed). > > Regards, > -- > Yann Dirson | Why make M$-Bill richer & richer ? > Debian-related: | Support Debian GNU/Linux: > Pro: | Freedom, Power, Stability, Gratuity > http://ydirson.free.fr/ | Check Of course, you can fix all this stuff by executing this ;^) #!/bin/bash # Temporarily fixes existing modules to contain the GPL symbol # TMPF=/tmp/Abradabrca VER=`uname -r` cat >${TMPF}.c < MODULE_LICENSE("GPL"); EOF gcc -Wall -O2 -c -o ${TMPF}.o ${TMPF}.c for x in `find /lib/modules/${VER} -name "*.o"` ; do echo $x ; cp $x /tmp/x.o ; ld -r /tmp/x.o ${TMPF}.o -o /tmp/y.o ; cp /tmp/y.o $x ; done echo "Fixed!" rm -f ${TMPF} /tmp/x.o /tmp/y.o Don't you love it when somebody undoes all this "lawyer" stuff! Cheers, Dick Johnson Penguin : Linux version 2.4.18 on an i686 machine (797.90 BogoMips). Windows-2000/Professional isn't. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/