Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754971Ab1DGPEZ (ORCPT ); Thu, 7 Apr 2011 11:04:25 -0400 Received: from terminus.zytor.com ([198.137.202.10]:57646 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753881Ab1DGPEY (ORCPT ); Thu, 7 Apr 2011 11:04:24 -0400 Message-ID: <4D9DD25D.9000000@zytor.com> Date: Thu, 07 Apr 2011 08:03:57 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110403 Fedora/3.1.9-6.fc15 Thunderbird/3.1.9 MIME-Version: 1.0 To: Peter Zijlstra CC: Thomas Gleixner , Ingo Molnar , Arnaldo Carvalho de Melo , Steven Rostedt , LKML Subject: Re: tip: New "Link:" tag to replace "LKML-Reference:" References: <4D9CE4AE.4090303@zytor.com> <1302185312.3329.1240.camel@twins> <4D9DCDAB.9000707@zytor.com> <1302188050.9086.27.camel@twins> In-Reply-To: <1302188050.9086.27.camel@twins> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 37 On 04/07/2011 07:54 AM, Peter Zijlstra wrote: > > Can't we use a prepare-commit-msg or commit-msg hook to re-write the > commit message to include a Link tag when one is missing, using > something like: > > Link: http://lkml.kernel.org/r/tip-$SHA@git.kernel.org > > And have the post-commit hook that sends the messages recognize this > form and send the message using the correct msgid. > > That way the commit includes a correct and clickable link, doesn't > require magic knowledge and doesn't need the committer to do extra work. > To summarize the problem I hinted at earlier: 1. The link that ends up in the commit message needs to be unique, or it is not going to be a working future-clickable link. 2. The link that ends up in the commit message CANNOT use the SHA1 of the commit itself, since the commit SHA1 is derived from the entire commit object including the message; 3. As a result, the only option is for the robot to change the Message-ID to something other than the SHA1 of the commit. It is a bit unfortunate, but probably not disastrous. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/