Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551Ab1DGQYY (ORCPT ); Thu, 7 Apr 2011 12:24:24 -0400 Received: from mail-gx0-f174.google.com ([209.85.161.174]:49886 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694Ab1DGQYW convert rfc822-to-8bit (ORCPT ); Thu, 7 Apr 2011 12:24:22 -0400 MIME-Version: 1.0 In-Reply-To: <20110405030428.GB29522@ponder.secretlab.ca> References: <20110202195417.228e2656@queued.net> <20110202200812.3d8d6cba@queued.net> <20110331230522.GI437@ponder.secretlab.ca> <20110401112030.GA3447@sortiz-mobl> <20110401104756.2f5c6f7a@debxo> <20110401235239.GE29397@sortiz-mobl> <20110404100314.GC2751@sortiz-mobl> <20110405030428.GB29522@ponder.secretlab.ca> From: Grant Likely Date: Thu, 7 Apr 2011 09:24:01 -0700 X-Google-Sender-Auth: -hpcnh-PGnFzMvZD2r-jrlhxws4 Message-ID: Subject: Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers To: Samuel Ortiz Cc: Andres Salomon , linux-kernel@vger.kernel.org, Mark Brown , khali@linux-fr.org, ben-linux@fluff.org, Peter Korsgaard , Mauro Carvalho Chehab , David Brownell , linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, spi-devel-general@lists.sourceforge.net, Mocean Laboratories , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1592 Lines: 42 On Mon, Apr 4, 2011 at 8:04 PM, Grant Likely wrote: > On Mon, Apr 04, 2011 at 12:03:15PM +0200, Samuel Ortiz wrote: >> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h >> index d96db98..734d254 100644 >> --- a/include/linux/platform_device.h >> +++ b/include/linux/platform_device.h >> @@ -14,6 +14,8 @@ >> ?#include >> ?#include >> >> +struct mfd_cell; >> + >> ?struct platform_device { >> ? ? ? const char ? ? ?* name; >> ? ? ? int ? ? ? ? ? ? id; >> @@ -23,6 +25,9 @@ struct platform_device { >> >> ? ? ? const struct platform_device_id *id_entry; >> >> + ? ? /* MFD cell pointer */ >> + ? ? struct mfd_cell *mfd_cell; >> + > > Move this down to by the of_node pointer. ?May as well collect all the > supplemental data about the device in the same place. So, okay. wow. I have *no* idea what I was smoking at this point in time. The of_node pointer is in struct device which is definitely not the place to put the mfd_cell pointer (and you probably though I was crazy when I suggested it). Greg was totally right to complain about moving it into struct device. Sorry for causing trouble. Move it back into struct platform_device and you should be good. I just talked to greg, and there should be any issues with locating it there. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/