Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932089Ab1DGT4j (ORCPT ); Thu, 7 Apr 2011 15:56:39 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:46450 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756719Ab1DGT4h (ORCPT ); Thu, 7 Apr 2011 15:56:37 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=CDaCKVVVLK/EMuWpL19HfsUjvJXgbdWRa1Wsx5IPFp251dyMpjliIWGA/Dyj1sloFy sRUV9/onoq1Y8JEwFCzjml1RQgoch3YdhD1CP38QAM0HmqXkydPoErs+hD9URLljtKea DVs31aHD6tLnBFOV73PKnBhzweg49BYH7qs3c= Subject: Re: [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in lme_firmware_switch() From: Malcolm Priestley To: Jesper Juhl Cc: Mauro Carvalho Chehab , David =?ISO-8859-1?Q?H=E4rdeman?= , Jarod Wilson , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Thu, 07 Apr 2011 20:56:25 +0100 Message-ID: <1302206185.2846.2.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 36 On Thu, 2011-04-07 at 21:46 +0200, Jesper Juhl wrote: > Don't leak 'fw' in > drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to > call release_firmware(). > > Signed-off-by: Jesper Juhl > --- > lmedm04.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > compile tested only > > diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c > index cd26e7c..d7cc625 100644 > --- a/drivers/media/dvb/dvb-usb/lmedm04.c > +++ b/drivers/media/dvb/dvb-usb/lmedm04.c > @@ -799,7 +799,7 @@ static int lme_firmware_switch(struct usb_device *udev, int cold) > if (cold) { > info("FRM Changing to %s firmware", fw_lme); > lme_coldreset(udev); > - return -ENODEV; > + ret = -ENODEV; > } > > release_firmware(fw); This has already been fixed in this commit http://git.linuxtv.org/media_tree.git?a=commit;h=b328817a2a391d1e879c4252cd3f11a352d3f3bc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/