Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756367Ab1DHJ6f (ORCPT ); Fri, 8 Apr 2011 05:58:35 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:51536 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755995Ab1DHJ5v (ORCPT ); Fri, 8 Apr 2011 05:57:51 -0400 From: pavan_savoy@ti.com To: greg@kroah.com, linux-kernel@vger.kernel.org Cc: pavan_savoy@sify.com, Victor Goldenshtein , Pavan Savoy Subject: [PATCH 3/3] drivers:misc:ti-st: fix skip remote baud logic Date: Fri, 8 Apr 2011 04:57:44 -0500 Message-Id: <1302256664-23688-4-git-send-email-pavan_savoy@ti.com> X-Mailer: git-send-email 1.5.6.3 In-Reply-To: <1302256664-23688-3-git-send-email-pavan_savoy@ti.com> References: <1302256664-23688-1-git-send-email-pavan_savoy@ti.com> <1302256664-23688-2-git-send-email-pavan_savoy@ti.com> <1302256664-23688-3-git-send-email-pavan_savoy@ti.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2023 Lines: 53 From: Victor Goldenshtein Texas Instruments WiLink connectivity combo chipsets support custom baud rates over its UART interface. This can be achieved by sending the change remote baud rate command. Since the baud rate can be properly set by the user-space on shared transport the remote chip-side and local host-side baud rate is change by the User Space Init Manager. This patch when encounters the same command inside the firmware, attempts to skip such command since it is handled by the user-space. The logic to skip the command when it is un-commented is fixed by this patch. Signed-off-by: Pavan Savoy Author: Victor Goldenshtein --- drivers/misc/ti-st/st_kim.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index 9ee4c78..b638a7d 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -244,9 +244,9 @@ void skip_change_remote_baud(unsigned char **ptr, long *len) pr_err("invalid action after change remote baud command"); } else { *ptr = *ptr + sizeof(struct bts_action) + - ((struct bts_action *)nxt_action)->size; + ((struct bts_action *)cur_action)->size; *len = *len - (sizeof(struct bts_action) + - ((struct bts_action *)nxt_action)->size); + ((struct bts_action *)cur_action)->size); /* warn user on not commenting these in firmware */ pr_warn("skipping the wait event of change remote baud"); } @@ -385,6 +385,8 @@ static long download_firmware(struct kim_data_s *kim_gdata) } /* fw download complete */ release_firmware(kim_gdata->fw_entry); + if (len != 0) + pr_err("%s:failed, script not parsed completely", __func__); return 0; } -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/