Date: Fri, 8 Apr 2011 11:14:55 -0400
From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Steve Rago <sar@nec-labs.com>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Allow O_SYNC to be set by fcntl(F_SETFL)
Message-ID: <20110408151454.GA1444@infradead.org>
References: <4D6824A4.6030009@nec-labs.com>
 <20110407143719.4044c00d.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110407143719.4044c00d.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 861
Lines: 18

I actually prototypes this patch independetly a while ago, and in
addition to the data writeout when removing O_SYNC there are the
following caveats:

 - O_SYNC is not actually one flag, but two: O_DSYNC and __O_SYNC.
   setfl() needs to make sure __O_SYNC cannot be in f_flags without
   O_DSYNC also beeing present.
 - we need to audit all filesystems that they don't do stupid things
   when the O_SYNC flags appear or disappear during a write, that
   is make sure it is checked in just one place.  The generic write
   code is fine in that respect, but I didn't go through all filesystems
   to verify it yet.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/