Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757199Ab1DHRfT (ORCPT ); Fri, 8 Apr 2011 13:35:19 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:43065 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756466Ab1DHRfQ (ORCPT ); Fri, 8 Apr 2011 13:35:16 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=gsN9N+npGVgyGyNarnleuAs95ljV+tRTWKn+qKE4H4mdik5hzOURM9sq4DtYgeJIDK fANn8n8GypCrA/bXS6RTHbAp26JmkLi6NWGLAD8DXX4yGlw7I24U/6hZXSN8kOIV9e2F Z+wWHO6YcXUU1dscInsJW+HI1fMQYO5tPyCfE= From: Frederic Weisbecker To: LKML Cc: LKML , Frederic Weisbecker , Ingo Molnar , Peter Zijlstra , Will Deacon , Prasad , Paul Mundt , Benjamin Herrenschmidt , "v2.6.33.." Subject: [PATCH 3/5] powerpc, hw_breakpoints: Fix racy access to ptrace breakpoints Date: Fri, 8 Apr 2011 19:34:25 +0200 Message-Id: <1302284067-7860-4-git-send-email-fweisbec@gmail.com> X-Mailer: git-send-email 1.7.3.2 In-Reply-To: <1302284067-7860-1-git-send-email-fweisbec@gmail.com> References: <1302284067-7860-1-git-send-email-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 43 While the tracer accesses ptrace breakpoints, the child task may concurrently exit due to a SIGKILL and thus release its breakpoints at the same time. We can then dereference some freed pointers. To fix this, hold a reference on the child breakpoints before manipulating them. Reported-by: Oleg Nesterov Signed-off-by: Frederic Weisbecker Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Will Deacon Cc: Prasad Cc: Paul Mundt Cc: Benjamin Herrenschmidt Cc: v2.6.33.. --- arch/powerpc/kernel/ptrace.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c index 895b082..330df91 100644 --- a/arch/powerpc/kernel/ptrace.c +++ b/arch/powerpc/kernel/ptrace.c @@ -1591,7 +1591,10 @@ long arch_ptrace(struct task_struct *child, long request, } case PTRACE_SET_DEBUGREG: + if (ptrace_get_breakpoints(child) < 0) + return -ESRCH; ret = ptrace_set_debugreg(child, addr, data); + ptrace_put_breakpoints(child); break; #ifdef CONFIG_PPC64 -- 1.7.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/