Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753877Ab1DIHyK (ORCPT ); Sat, 9 Apr 2011 03:54:10 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:54314 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753708Ab1DIHyJ convert rfc822-to-8bit (ORCPT ); Sat, 9 Apr 2011 03:54:09 -0400 MIME-Version: 1.0 X-Originating-IP: [109.186.51.37] In-Reply-To: <1302294509-6595-1-git-send-email-mathieu.poirier@linaro.org> References: <1302294509-6595-1-git-send-email-mathieu.poirier@linaro.org> From: Ohad Ben-Cohen Date: Sat, 9 Apr 2011 10:53:48 +0300 Message-ID: Subject: Re: [PATCH] ux500: Adding support for u8500 Hsem functionality. To: mathieu.poirier@linaro.org Cc: linux-arm-kernel@lists.infradead.org, lee.jones@linaro.org, patches@linaro.org, linus.walleij@stericsson.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 35 Hi Mathieu, On Fri, Apr 8, 2011 at 11:28 PM, wrote: ... > + * Author: Mathieu Poirier > + * Heavily borrowed from the work of : > + * ? Simon Que > + * ? Hddari Kanigeri s/Hddari/Hari/ > + ? ? ? platform_set_drvdata(pdev, state); > + > + ? ? ? /* no pm needed for HSem but required to comply > + ? ? ? ?* with hwspilock core. > + ? ? ? ?*/ > + ? ? ? pm_runtime_enable(&pdev->dev); You seem to have removed the calls to pm_runtime_disable() throughout the driver, is that on purpose ? You should see an "Unbalanced pm_runtime_enable!" warning about this if you tried rmmod'ing and insmod'ing the driver again. And just a minor comment if you're submitting a v2: you have a bunch of trailing whitespaces; try checkpatch to spot them easily. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/