Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754184Ab1DKQ72 (ORCPT ); Mon, 11 Apr 2011 12:59:28 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:46395 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754004Ab1DKQ7Z convert rfc822-to-8bit (ORCPT ); Mon, 11 Apr 2011 12:59:25 -0400 MIME-Version: 1.0 In-Reply-To: <20110411173409.1567679c@lxorguk.ukuu.org.uk> References: <20110409000857.GB25581@piper> <20110411173409.1567679c@lxorguk.ukuu.org.uk> Date: Mon, 11 Apr 2011 13:59:23 -0300 Message-ID: Subject: Re: 2.6.39-rc2 regression: X201s fails to resume b77dcf8460ae57d4eb9fd3633eb4f97b8fb20716 From: Vinicius Gomes To: Alan Cox Cc: Keith Packard , Thomas Gleixner , linux-kernel , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 40 Hi Gustavo, On Mon, Apr 11, 2011 at 1:34 PM, Alan Cox wrote: >> I took a shot at it and just sent a patch (also attached for convenience) >> that should solve the problem. > > Well its reverting too much but its also looking pretty bogus to me > > -       /* Stop timer, it might be running */ > -       del_timer_sync(&hdev->cmd_timer); > - >        if (!test_and_clear_bit(HCI_UP, &hdev->flags)) { >                hci_req_unlock(hdev); >                return 0; > > So you've now got a path where you leave the timer running and didn't > before - not it appears one that is a good idea. > > Certainly not the kind of change that should be considered for a > regression fix for an rc kernel. It's far too big a behavioural change to > be safe. Considering what was said and that this patch didn't hit your public tree yet, I guess that this patch should be ignored. Will send a proper fix soon. Thanks all. > > Alan > Cheers, -- Vinicius -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/