Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755966Ab1DKV0J (ORCPT ); Mon, 11 Apr 2011 17:26:09 -0400 Received: from gate.crashing.org ([63.228.1.57]:57110 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754004Ab1DKV0H (ORCPT ); Mon, 11 Apr 2011 17:26:07 -0400 Subject: Re: [PATCH 3/6] microblaze/pci: Move the remains of pci_32.c to pci-common.c From: Benjamin Herrenschmidt To: Rolf Eike Beer Cc: linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, bheglaas@google.com, monstr@monstr.eu, tglx@linutronix.de, bigeasy@linutronix.de In-Reply-To: References: <1302495170-973-1-git-send-email-benh@kernel.crashing.org> <1302495170-973-4-git-send-email-benh@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 12 Apr 2011 07:25:33 +1000 Message-ID: <1302557133.28876.13.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 32 On Mon, 2011-04-11 at 15:12 +0000, Rolf Eike Beer wrote: > > There's no point in keeping this separate. Even if microblaze grows > > a 64-bit variant, it will probably be able to re-use that code as-is > > > diff --git a/arch/microblaze/pci/pci-common.c > > b/arch/microblaze/pci/pci-common.c > > index 5359906..041b1d8 100644 > > --- a/arch/microblaze/pci/pci-common.c > > +++ b/arch/microblaze/pci/pci-common.c > > @@ -50,6 +50,11 @@ unsigned int pci_flags; > > > > static struct dma_map_ops *pci_dma_ops = &dma_direct_ops; > > > > +unsigned long isa_io_base; > > +unsigned long pci_dram_offset; > > +static int pci_bus_count; > > + > > + > > Extra newline. Can people with no useful content abstain from commenting please. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/