Date: Tue, 12 Apr 2011 14:33:40 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>, linux-kernel@vger.kernel.org,
        behlendorf1@llnl.gov, oleg@redhat.com
Subject: Re: [PATCH] remove abs64()
Message-Id: <20110412143340.e26fc370.akpm@linux-foundation.org>
In-Reply-To: <20110412211658.GB20135@p183>
References: <20110412210045.GA19901@p183>
	<20110412140726.3f4f2a7b.rdunlap@xenotime.net>
	<20110412141040.a5706346.akpm@linux-foundation.org>
	<20110412211658.GB20135@p183>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1034
Lines: 29

On Wed, 13 Apr 2011 00:16:58 +0300
Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Tue, Apr 12, 2011 at 02:10:40PM -0700, Andrew Morton wrote:
> > On Tue, 12 Apr 2011 14:07:26 -0700
> > Randy Dunlap <rdunlap@xenotime.net> wrote:
> > 
> > > > +	__builtin_choose_expr(						\
> > > > +		__builtin_types_compatible_p(typeof(_x), long long),	\
> > > > +		(unsigned long long)({ _x < 0 ? -_x : _x; }),		\
> > > > +	_x)))));							\
> > > > +})
> > > 
> > > that is better?
> > 
> > I think so.
> > 
> > It's a bit concerning that it changes the return type of abs().
> 
> I haven't read every abs() user, but, yes, sizeof(abs()) silently
> changing is the issue.

It changes signedness_of(abs(signed_expr)) as well.  That changes the
signedness of expressions which use abs() and on and on.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/